-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add website #50
Add website #50
Conversation
@ll-nick Ready for review and merging. We should change the GitHub Pages branch setting to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good and the docker setup works (almost) like a charm, thank you! 🚀
Also very nice work in keeping the root directory clean. 🧹
Maybe you have an idea for these two things, otherwise feel free to merge :)
- The browser tab title is currently:
ARBITRATION_GRAPHS | Arbitration Graphs
I tried changing it using atitle:
in the_config.yml
but that only affects the second half. I did not manage to change the first half. I would imagine it being either onlyArbitration Graphs
or something likeArbitration Graphs | Home
since we want to have different pages. - About the docker setup: I did not manage to get it to work at first because my root directory contained the compile_commands.json. Since that is a symlink generated in the dev container, it points to something like
/home/blinky
which is apparently something jekyll is not able not handle, even if you add it to theexclude:
setting. I solved it by removing the link, not sure if there is a better option.
# This is a config file for Jekyll, the static site generator used by GitHub Pages. | ||
# | ||
# In our setup, the top-level README.md is the landing page, | ||
# while the rest of the pages and all assets are in the docs folder. | ||
# | ||
# This way, we can use the main branchs' README.md as main website, | ||
# add subpages for the tutorial and deep dive docs, | ||
# while avoiding Jekyll clutter in the repo root. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh and once we solved #49, we should definitely add a |
Done, see ad495ac
I don't know how you've setup your dev container. But when using our docker compose setups, the Maybe, you had issues with the demo build setup. |
Yeah, nevermind the compile commands thing. I am honestly not sure why the link was even there in the first place, my LSP works just fine without it 🤷♂️ |
This closes #33