Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken links in the GitHub pages menu #94

Merged
merged 2 commits into from
Nov 27, 2024
Merged

Fix broken links in the GitHub pages menu #94

merged 2 commits into from
Nov 27, 2024

Conversation

orzechow
Copy link
Member

This fixes broken tutorial menu links.

They had absolute links that worked on a local jekyll setup, but not on GitHub Pages with a baseurl other than /.

#patch

ll-nick
ll-nick approved these changes Nov 27, 2024
View reviewed changes
Copy link
Collaborator

@ll-nick ll-nick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if I can test this locally when it's only broken on github but I'll trust that you know what you are doing with this one :)

@orzechow
Copy link
Member Author

Yes, you can 😁

See the comment in the _config.yml
Make sure to adjust the browser url as well:
http://0.0.0.0:4000/base/

@orzechow orzechow merged commit 0285e0a into main Nov 27, 2024
1 check passed
@orzechow orzechow deleted the fix_github_pages_menu branch November 27, 2024 08:11
@orzechow orzechow mentioned this pull request Nov 28, 2024
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ll-nick ll-nick ll-nick approved these changes

@ChristophBurger89 ChristophBurger89 Awaiting requested review from ChristophBurger89 ChristophBurger89 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@orzechow @ll-nick