Solution files are overwritten

[RomanLangrehr]

I experienced the following issue: When a user uploads two files for the same task and I annotate (as tutor) only one of them in the attestation page, the untouched file gets overwritten with content of the edited file, too.

I'm not sure if this is important, but I first edited both files, saved my work and later I edited one of the files again and then this issue appeared.

[ifrh]

Hi,

At my Praktomat installation, we use our AutoAttestChecker (pull request is #264 ) - so no human interation happens to create attestations for student solutions. We don't have any tutor as Praktomat user.
Could you please give more details?
Can you annotate while upload time is not over?
Do you annotate after or befor "run all checker"?

Best regards

[ifrh]

I think your situation is unrelated to a "resubmit" bug ( issue #232 and its unmerged fix in pullrequest #266 ) : Since you open that issue about four years ago: Is it a current problem, too ?

[physikerwelt]

This bug is still present!

[ifrh]

Given a student uploads two files in one solution, and a tutor edit both files. That "comment" is saved. But if tutor comment only one file again, than both comented files have identical content.

In "edit_attestation" https://github.com/KITPraktomatTeam/Praktomat/blob/master/src/attestation/views.py#L343
incances of AnnotatedFileFormSet are used which depends on AnnotatedFileForm. In AnnotatedFileForm there is defined solution_file as IntegerField, see https://github.com/KITPraktomatTeam/Praktomat/blob/master/src/attestation/forms.py#L40

I do not get it. Why it is not a Textfield or a FieleField ?

[ifrh]

at our side problem with overwritten annotated files were gone after

git submodule sync --recursive
git submodule update --init --recursive

[ifrh]

at our side problem with overwritten annotated files were gone after

git submodule sync --recursive
git submodule update --init --recursive

Perhaps the reason was a bug inside a submodule ...

I vote for closing this issue (and reopen it, if the problem returns).