Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data recording for pods/cockpits #109

Open
anxcon opened this issue Feb 16, 2016 · 2 comments
Open

data recording for pods/cockpits #109

anxcon opened this issue Feb 16, 2016 · 2 comments

Comments

@anxcon
Copy link
Collaborator

anxcon commented Feb 16, 2016

this has been delayed due to potential compound part
(some pods have engines, rcs, reaction wheel, etc)
so a flight recorder from any single system would not work

going to make a compound recorder for multi system, this case for command pods / cockpits, and thus one condition to be met (before checking others) that the part be current control-from part

after that i have 2 options, either constant data tick over time, or only data tick when another system is active, which so far the list is:
engines
rcs
reaction wheel
yaw/pitch/roll (one of them not being zeroed)

so go direction 1, or list more options for direction 2

@jwvanderbeck
Copy link
Collaborator

This gets a bit tricky and you are basically talking about composition here.

Maybe make it so that FlightDataRecorder has a config field that is a list of part modules, and if present only tick data if those modules are all enabled or active. But then it gets more confusing when you might have complex definitions of active, but it would at least work for things like avionics.

In the case of multipart assemblies, like Pods with thrusters built into the same part, well these parts just suck :p And we need a better way to handle them, but I am afraid that will require some deeper thought and probably some major refactoring.

@anxcon
Copy link
Collaborator Author

anxcon commented Mar 5, 2016

thinking to make a more generic recorder, and set fields to true for what checks to do....

then again, having recorders able to have a 'slave' mode, literally doing nothing, but allowing multiple slaves to exist, could (once that mess is figured out) be easy to call all recorder modules to ask isPartOperating, thus only needing the check code in their specific recorders, and 1 master to fetch em

random thoughts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants