Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extremely long restart windows cause game freeze #256

Open
Capkirk123 opened this issue Nov 17, 2022 · 4 comments
Open

Extremely long restart windows cause game freeze #256

Capkirk123 opened this issue Nov 17, 2022 · 4 comments
Labels

Comments

@Capkirk123
Copy link
Member

The RO S5.92 and S5.98M engine configs have started freezing the game when they are moused over. This seems to be caused by their extremely long (300 day) restart windows, as removing the restart windows fixes the crashes.
This change to RO changing the TF config structure seems to be the cause, these issues started appearing after it was merged, but it doesn't effect any of the restart window patching or logic. Since I'm not entirely sure what's responsible for the issue, I'm just opening the issue here.
KSP-RO/RealismOverhaul#2725

@Capkirk123 Capkirk123 added the bug label Nov 17, 2022
@lpgagnon
Copy link
Contributor

n.b. the reason this started happening with RO#2725 is that the TF patches on those two engines were just broken previously; they used the wrong config names and didn't get applied at all (s5.98m vs s5-98m)

@jwvanderbeck
Copy link
Collaborator

public List<string> RestartCurveDescription()

Most likely the problem is the code that describes the restart curves is just too slow for so large a restart window

@Capkirk123
Copy link
Member Author

Oh yeah, those were engines that weren't getting configs applied correctly, in which case the 300 day window was never working in the first place. Unless anyone has any ideas on how to make the code more efficient, it's probably best to just avoid values that large.

@MikeOnTea
Copy link

MikeOnTea commented Nov 17, 2022

Instead of evaluating a curve over 300 days every 10 ms (!) just to generate descriptions for the UI, what about either implementing some kind of back off or even better, just reading the keys of the curves directly and iterating over them to generate information that's probably good enough?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants