-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extremely long restart windows cause game freeze #256
Comments
n.b. the reason this started happening with RO#2725 is that the TF patches on those two engines were just broken previously; they used the wrong config names and didn't get applied at all (s5.98m vs s5-98m) |
Most likely the problem is the code that describes the restart curves is just too slow for so large a restart window |
Oh yeah, those were engines that weren't getting configs applied correctly, in which case the 300 day window was never working in the first place. Unless anyone has any ideas on how to make the code more efficient, it's probably best to just avoid values that large. |
Instead of evaluating a curve over 300 days every 10 ms (!) just to generate descriptions for the UI, what about either implementing some kind of back off or even better, just reading the keys of the curves directly and iterating over them to generate information that's probably good enough? |
The RO S5.92 and S5.98M engine configs have started freezing the game when they are moused over. This seems to be caused by their extremely long (300 day) restart windows, as removing the restart windows fixes the crashes.
This change to RO changing the TF config structure seems to be the cause, these issues started appearing after it was merged, but it doesn't effect any of the restart window patching or logic. Since I'm not entirely sure what's responsible for the issue, I'm just opening the issue here.
KSP-RO/RealismOverhaul#2725
The text was updated successfully, but these errors were encountered: