Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert panics into error returns in load.rs #5

Open
KarelPeeters opened this issue Mar 5, 2024 · 0 comments
Open

Convert panics into error returns in load.rs #5

KarelPeeters opened this issue Mar 5, 2024 · 0 comments

Comments

@KarelPeeters
Copy link
Owner

Currently load.rs can panic for many reasons:

  • An invalid onnx file was given
  • An unsupported operator was used
  • An unsupported combination of operator/shape/attributes was used.

None of these should cause panics, these should all be errors with human-readable explanations. It doesn't have to be a nice enum type, just strings is already a good start. Panics should only be triggerable by implementation bugs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant