Skip to content

Commit 9398d28

Browse files
committed
Errorbars implemented. Closes #6
1 parent 775ac5f commit 9398d28

File tree

1 file changed

+8
-11
lines changed

1 file changed

+8
-11
lines changed

setup.js

+8-11
Original file line numberDiff line numberDiff line change
@@ -229,7 +229,6 @@ function initCrossfilter() {
229229

230230
if(p.count>1)
231231
p.var = p.count
232-
p.stddev = Math.sqrt(p.var);
233232
p.erN_1948 = factor_indep * 2 * Math.sqrt( (p.var/N_1948) * (N_1948 - p.var) );
234233
p.erN_1956 = factor_indep * 2 * Math.sqrt( (p.var/N_1956) * (N_1956 - p.var) );
235234
p.erN_1966 = factor_indep * 2 * Math.sqrt( (p.var/N_1966) * (N_1966 - p.var) );
@@ -245,7 +244,6 @@ function initCrossfilter() {
245244

246245
if(p.count>1)
247246
p.var = p.count
248-
p.stddev = Math.sqrt(p.var);
249247
p.erN_1948 = factor_indep * 2 * Math.sqrt( (p.var/N_1948) * (N_1948 - p.var) );
250248
p.erN_1956 = factor_indep * 2 * Math.sqrt( (p.var/N_1956) * (N_1956 - p.var) );
251249
p.erN_1966 = factor_indep * 2 * Math.sqrt( (p.var/N_1966) * (N_1966 - p.var) );
@@ -617,7 +615,7 @@ function initCrossfilter() {
617615
stroke: errorbarColour,
618616
x1: function(d) {
619617
//Display errorbar corresponding to specific decade
620-
var decade = this.parentNode.__data__.key;
618+
var decade = this.parentNode.__data__.key;
621619

622620
if (decade === "1948-1955") er_decade = d.value.erN_1948;
623621
else if (decade === "1956-1965") er_decade = d.value.erN_1956;
@@ -655,17 +653,14 @@ function initCrossfilter() {
655653
stroke: errorbarColour,
656654
x1: function(d) {
657655
var decade = this.parentNode.__data__.key;
658-
659-
// junk = chart.select('.' + decade + ' .erline_horizontal').attr("x1")
660-
// junk = decadeChart.select('.' + decade )
661-
// console.log("junk: ", junk)
662-
return chart.x()(d.value.count - d.value.stddev);
656+
return chart.select('.decade' + decade + ' .erline_horizontal').attr("x1");
663657
},
664658
y1: function(d) {
665659
return barHeight/2 - endwid;
666660
},
667661
x2: function(d) {
668-
return chart.x()(d.value.count - d.value.stddev);
662+
var decade = this.parentNode.__data__.key;
663+
return chart.select('.decade' + decade + ' .erline_horizontal').attr("x1");
669664
},
670665
y2: function(d) {
671666
return barHeight/2 + endwid;
@@ -676,13 +671,15 @@ function initCrossfilter() {
676671
'stroke-width': 1,
677672
stroke: errorbarColour,
678673
x1: function(d) {
679-
return chart.x()(d.value.count + d.value.stddev);
674+
var decade = this.parentNode.__data__.key;
675+
return chart.select('.decade' + decade + ' .erline_horizontal').attr("x2");
680676
},
681677
y1: function(d) {
682678
return barHeight/2 - endwid;
683679
},
684680
x2: function(d) {
685-
return chart.x()(d.value.count + d.value.stddev);
681+
var decade = this.parentNode.__data__.key;
682+
return chart.select('.decade' + decade + ' .erline_horizontal').attr("x2");
686683
},
687684
y2: function(d) {
688685
return barHeight/2 + endwid;

0 commit comments

Comments
 (0)