Skip to content

Update dbmigrate-lib mysql version #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mentalbrew opened this issue Sep 28, 2017 · 3 comments
Closed

Update dbmigrate-lib mysql version #24

mentalbrew opened this issue Sep 28, 2017 · 3 comments

Comments

@mentalbrew
Copy link

Build is failing on stable Rust (1.20.0):

error: type `io::IoPack + 'static` is private
    --> /home/mentalbrew/.cargo/registry/src/github.com-1ecc6299db9ec823/mysql-10.0.0/src/conn/mod.rs:1044:30
     |
1044 |         let (data, seq_id) = self.get_mut_stream().as_mut().read_packet(old_seq_id)?;
     |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

error: type `io::IoPack + 'static` is private
    --> /home/mentalbrew/.cargo/registry/src/github.com-1ecc6299db9ec823/mysql-10.0.0/src/conn/mod.rs:1051:22
     |
1051 |         let seq_id = self.get_mut_stream().as_mut().drop_packet(old_seq_id)?;
     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

error: type `io::IoPack + 'static` is private
    --> /home/mentalbrew/.cargo/registry/src/github.com-1ecc6299db9ec823/mysql-10.0.0/src/conn/mod.rs:1059:23
     |
1059 |         self.seq_id = self.get_mut_stream().as_mut().write_packet(data, seq_id, max_allowed_packet)?;
     |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

error: aborting due to 3 previous errors

Searching for this error revealed this support issue for the compiler:
rust-lang/rust#43662

The simplest path seems to be upgrading to a newer version of mysql crate. Is there any issue with doing so?

@Keats
Copy link
Owner

Keats commented Sep 28, 2017

I've noticed that yesterday but didn't have time to fix it yet. There shouldn't be any issue upgrading mysql, i'll take a PR for it or I'll do it today/this weekend.

Keats pushed a commit that referenced this issue Sep 29, 2017
@Keats Keats closed this as completed in #25 Sep 29, 2017
@Keats
Copy link
Owner

Keats commented Sep 29, 2017

Just pushed a new version to crates.io that should fix the issue!

@mentalbrew
Copy link
Author

Thank you! By the time I was available to work on it, you already had the fix in. Much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants