Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for non-assignment of MAM policies #1319

Open
wants to merge 31 commits into
base: dev
Choose a base branch
from

Conversation

markheydon
Copy link

App Protection policies use difference Graph resource for assignment, this passes that into the assign script to use when needed.

markheydon and others added 26 commits January 15, 2025 19:22
[pull] master from KelvinTegelaar:master
[pull] master from KelvinTegelaar:master
[pull] master from KelvinTegelaar:master
[pull] master from KelvinTegelaar:master
[pull] master from KelvinTegelaar:master
[pull] master from KelvinTegelaar:master
[pull] master from KelvinTegelaar:master
[pull] master from KelvinTegelaar:master
@markheydon
Copy link
Author

Only tested locally and via manual assignment at this point, waiting for Standards to run to see what happens then on a production instance.

@markheydon markheydon changed the title Fix for non-assignment of MAM policies. Fix for non-assignment of MAM policies Feb 25, 2025
@markheydon
Copy link
Author

@JohnDuprey fix worked on several overnight Standards runs, in that no errors now and policies are getting assigned to the custom groups. But exclusions aren't working by the looks (if they ever did?). Will look shortly at the exclusions issue.

@markheydon
Copy link
Author

@JohnDuprey fixed issue of excluded groups not being process from Standards run. As per chat earlier though, obviously keep in mind this is the first time I've submitted a PR and can't say for 100% certainty I've caught all possible places the -ExcludeGroup stuff was missing. Certainly, working ok on Standards run locally for me now, and currently no support in the UI for manually deployed policies re an excluded group.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants