Skip to content

Support for smoothing? #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kylefox opened this issue Feb 13, 2010 · 2 comments
Open

Support for smoothing? #3

kylefox opened this issue Feb 13, 2010 · 2 comments

Comments

@kylefox
Copy link

kylefox commented Feb 13, 2010

Does grafico support Kernel smoothing? I couldn't find anything in the docs to suggest it does, but thought I'd double check.

I'm interested in using grafico, but my application requires Kernel-smoothed values (I already have the code for calculating interpolations). I would be willing to contribute this code to grafico if it's something other people find useful.

@janpaul123
Copy link

Currently there are no smoothing options other than simply curving the line graphs with curve_amount. Smoothing options would be pretty nice to have as in my stream graph implementation (in my fork) it's hard to get the wiggle out.

Also, it'd be nice to have code that draws lines better through the fixed points, as now a Bezier curve is used simply by drawing control points at (x1+curve_amount, y1) and (x2-curve_amount, y2) which is nice if you have alternating data (up, down, up, etc.) but not when you have a steady rise or fall in the data.

I don't know if you've got the answer to that, but it'd already be nice to have the Kernel smoothing. Also, maybe it's wise to wait until Kilian has pulled my changes as there are some changes in drawing the data, or pull from my repository: not to be hostile and take over the fork, but at the moment it's more up to date.

@Kilian
Copy link
Owner

Kilian commented Feb 15, 2010

hey kylefox,

As janpaul123 said, it doesn't support it yet, but it would be very nice! I'll be pulling janpaul123's changes in the next couple of days and bring it all up to date, it would be very awesome if you would contribute kernel smoothing after that! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants