Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add consistent type hinting in fields.py #714

Closed
veedubb opened this issue Nov 6, 2024 · 1 comment
Closed

Add consistent type hinting in fields.py #714

veedubb opened this issue Nov 6, 2024 · 1 comment

Comments

@veedubb
Copy link
Contributor

veedubb commented Nov 6, 2024

Is your feature request related to a problem? Please describe.
This is not related to a specific problem, but is just to make the type hinting within the file consistent across both the LayerField and LayerFieldsContainer. The LayerField class is type hinted/annotated for non-dunder methods of the class, however the LayerFieldsContainer is missing similar type hints/annotations. Other non-private methods and functions throughout pyshark also offer similar type hinting to the LayerField class (XmlLayer).

Describe the solution you'd like
Similar type hinting/annotation in the LayerFieldsContainer class as the LayerField class.

Describe alternatives you've considered
Alternatively, type hinting/annotation could be removed, but based on the inclusion in other files it seems that type hinting/annotation is the correct application.

Additional context
None.

@veedubb
Copy link
Contributor Author

veedubb commented Dec 6, 2024

Closed with #717

@veedubb veedubb closed this as completed Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant