Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust 2024 Edition #64

Closed
vincentberthier opened this issue Jan 24, 2025 · 2 comments · Fixed by #65
Closed

Rust 2024 Edition #64

vincentberthier opened this issue Jan 24, 2025 · 2 comments · Fixed by #65

Comments

@vincentberthier
Copy link

Trying to use cargo-pgo on a project upgraded to the 2024 edition of Rust fails:
Cannot get cargo metadata: Json(Error("unknown variant 2024, expected one of 2015, 2018, 2021", line: 1, column: 378321))

This is due to version 0.15 of cargo_metadata not allowing 2024 as a valid version. This has been changed in newer versions however, so it might just be a matter of upgrading the dependency (to minimum 0.17.0).

@Kobzol Kobzol mentioned this issue Jan 24, 2025
@Kobzol
Copy link
Owner

Kobzol commented Jan 24, 2025

Good point! I will do that in #65, although I had some trouble with CI, so I will need to fix that first.

@vincentberthier
Copy link
Author

Cool, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants