Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate Client Code silently fails if an environment variable is undefined #4825

Open
1 task done
relgames opened this issue Jun 1, 2022 · 3 comments · May be fixed by #8355
Open
1 task done

Generate Client Code silently fails if an environment variable is undefined #4825

relgames opened this issue Jun 1, 2022 · 3 comments · May be fixed by #8355
Labels
B-bug Bug: general classification E-good-first-issue Experience required: Beginner / New S-verified Status: Verified by maintainer

Comments

@relgames
Copy link

relgames commented Jun 1, 2022 •
edited
Loading

Expected Behavior

Should be possible to generate a code with Generate Client Code dialog or via Copy as cUrl.

Actual Behavior

Generate Client Code dialog is not working - dropdowns are not working as well
Also Copy as cUrl is not working.

Screen.Recording.2022-06-01.at.14.32.53.mov

Reproduction Steps

  1. Click Generate Code in the request menu
  2. Try to click on dropdowns Shell or Wget

Is there an existing issue for this?

Additional Information

Version: Insomnia 2022.3.0
Build date: 4/28/2022
OS: Darwin x64 21.4.0
Electron: 17.3.1
Node: 16.13.0
V8: 9.8.177.13-electron.0
Architecture: x64

Insomnia Version

2022.3.0

What operating system are you using?

macOS

Operating System Version

macOS Monterey 12.3.1

Installation method

homebrew

Last Known Working Insomnia version

Not sure which version but it worked previously
@relgames relgames added B-bug Bug: general classification S-unverified Status: Unverified by maintainer labels Jun 1, 2022
@relgames
Copy link
Author

relgames commented Jun 1, 2022

Found the reason, one of variables was not defined - but it was not indicating it anywhere.
Need to display an error message.

@filfreire
Copy link
Member

Hi @relgames, thank you for reporting this! I was able to reproduce this as well.

Indeed this is a bug, we don't warn the user at the very least the same way we do when trying to send a request with an undefined variable.

This happens both for Generate Code and the Copy as Curl options. We are hiding the errors in both cases:

Screenshot 2022-06-02 at 11 34 29

Screenshot 2022-06-02 at 11 33 41
Screenshot 2022-06-02 at 11 33 37

@relgames I would like to encourage you to report any other issues you may find in the meantime 👍

@filfreire filfreire added E-good-first-issue Experience required: Beginner / New S-verified Status: Verified by maintainer and removed S-unverified Status: Unverified by maintainer labels Jun 2, 2022
@filfreire filfreire changed the title Generate Client Code is not working Generate Client Code does not safely throw if an environment variable is undefined Jul 28, 2022
@filfreire filfreire changed the title Generate Client Code does not safely throw if an environment variable is undefined Generate Client Code silently fails if an environment variable is undefined Jul 28, 2022
@filfreire filfreire mentioned this issue Jul 28, 2022
Closed
@rafael-almeida
Copy link

Hi all 👋

I am interested in working on this issue as my first contribution to the project. Is this still relevant? I'm eager to help out where I can.

@Karthik7406 Karthik7406 linked a pull request Feb 11, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
B-bug Bug: general classification E-good-first-issue Experience required: Beginner / New S-verified Status: Verified by maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix for generating code error if there are undefined variables Karthik7406/insomnia
3 participants
@relgames @filfreire @rafael-almeida