Document the existing serial descriptor names

dkhalanskyjb · dkhalanskyjb · commit faedbcc148ac · 2024-07-25T14:39:38.000+02:00
diff --git a/serialization/common/test/DateTimePeriodSerializationTest.kt b/serialization/common/test/DateTimePeriodSerializationTest.kt
@@ -97,28 +97,34 @@ class DateTimePeriodSerializationTest {
 
     @Test
     fun testDatePeriodIso8601Serialization() {
+        assertKSerializerName("kotlinx.datetime.DatePeriod", DatePeriodIso8601Serializer)
         datePeriodIso8601Serialization(DatePeriodIso8601Serializer, DateTimePeriodIso8601Serializer)
     }
 
     @Test
     fun testDatePeriodComponentSerialization() {
+        assertKSerializerName("kotlinx.datetime.DatePeriod", DatePeriodComponentSerializer)
         datePeriodComponentSerialization(DatePeriodComponentSerializer, DateTimePeriodComponentSerializer)
     }
 
     @Test
     fun testDateTimePeriodIso8601Serialization() {
+        assertKSerializerName("kotlinx.datetime.DateTimePeriod", DateTimePeriodIso8601Serializer)
         dateTimePeriodIso8601Serialization(DateTimePeriodIso8601Serializer)
     }
 
     @Test
     fun testDateTimePeriodComponentSerialization() {
+        assertKSerializerName("kotlinx.datetime.DateTimePeriod", DateTimePeriodComponentSerializer)
         dateTimePeriodComponentSerialization(DateTimePeriodComponentSerializer)
     }
 
     @Test
     fun testDefaultSerializers() {
         // Check that they behave the same as the ISO 8601 serializers
+        assertKSerializerName<DateTimePeriod>("kotlinx.datetime.DateTimePeriod", Json.serializersModule.serializer())
         dateTimePeriodIso8601Serialization(Json.serializersModule.serializer())
+        assertKSerializerName<DatePeriod>("kotlinx.datetime.DatePeriod", Json.serializersModule.serializer())
         datePeriodIso8601Serialization(Json.serializersModule.serializer(), Json.serializersModule.serializer())
     }
 
diff --git a/serialization/common/test/DateTimeUnitSerializationTest.kt b/serialization/common/test/DateTimeUnitSerializationTest.kt
@@ -18,7 +18,7 @@ class DateTimeUnitSerializationTest {
         repeat(100) {
             val nanoseconds = Random.nextLong(1, Long.MAX_VALUE)
             val unit = DateTimeUnit.TimeBased(nanoseconds)
-            val json = "{\"nanoseconds\":${nanoseconds.toString()}}" // https://youtrack.jetbrains.com/issue/KT-39891
+            val json = "{\"nanoseconds\":$nanoseconds}"
             assertEquals(json, Json.encodeToString(serializer, unit))
             assertEquals(unit, Json.decodeFromString(serializer, json))
         }
@@ -65,7 +65,7 @@ class DateTimeUnitSerializationTest {
         repeat(100) {
             val nanoseconds = Random.nextLong(1, Long.MAX_VALUE)
             val unit = DateTimeUnit.TimeBased(nanoseconds)
-            val json = "{\"type\":\"kotlinx.datetime.TimeBased\",\"nanoseconds\":${nanoseconds.toString()}}" // https://youtrack.jetbrains.com/issue/KT-39891
+            val json = "{\"type\":\"kotlinx.datetime.TimeBased\",\"nanoseconds\":$nanoseconds}"
             assertEquals(json, Json.encodeToString(serializer, unit))
             assertEquals(unit, Json.decodeFromString(serializer, json))
         }
@@ -87,21 +87,25 @@ class DateTimeUnitSerializationTest {
 
     @Test
     fun testTimeBasedUnitSerialization() {
+        assertKSerializerName("kotlinx.datetime.TimeBased", TimeBasedDateTimeUnitSerializer)
         timeBasedSerialization(TimeBasedDateTimeUnitSerializer)
     }
 
     @Test
     fun testDayBasedSerialization() {
+        assertKSerializerName("kotlinx.datetime.DayBased", DayBasedDateTimeUnitSerializer)
         dayBasedSerialization(DayBasedDateTimeUnitSerializer)
     }
 
     @Test
     fun testMonthBasedSerialization() {
+        assertKSerializerName("kotlinx.datetime.MonthBased", MonthBasedDateTimeUnitSerializer)
         monthBasedSerialization(MonthBasedDateTimeUnitSerializer)
     }
 
     @Test
     fun testDateBasedSerialization() {
+        assertKSerializerName("kotlinx.datetime.DateTimeUnit.DateBased", DateBasedDateTimeUnitSerializer)
         dateBasedSerialization(DateBasedDateTimeUnitSerializer)
     }
 
diff --git a/serialization/common/test/DayOfWeekSerializationTest.kt b/serialization/common/test/DayOfWeekSerializationTest.kt
@@ -13,10 +13,11 @@ import kotlin.test.*
 class DayOfWeekSerializationTest {
     @Test
     fun testSerialization() {
+        assertKSerializerName("kotlinx.datetime.DayOfWeek", DayOfWeekSerializer)
         for (dayOfWeek in DayOfWeek.entries) {
             val json = "\"${dayOfWeek.name}\""
             assertEquals(json, Json.encodeToString(DayOfWeekSerializer, dayOfWeek))
             assertEquals(dayOfWeek, Json.decodeFromString(DayOfWeekSerializer, json))
         }
     }
-}
+}
diff --git a/serialization/common/test/InstantSerializationTest.kt b/serialization/common/test/InstantSerializationTest.kt
@@ -54,17 +54,20 @@ class InstantSerializationTest {
 
     @Test
     fun testIso8601Serialization() {
+        assertKSerializerName("kotlinx.datetime.Instant", InstantIso8601Serializer)
         iso8601Serialization(InstantIso8601Serializer)
     }
 
     @Test
     fun testComponentSerialization() {
+        assertKSerializerName("kotlinx.datetime.Instant", InstantComponentSerializer)
         componentSerialization(InstantComponentSerializer)
     }
 
     @Test
     fun testDefaultSerializers() {
         // should be the same as the ISO 8601
+        assertKSerializerName<Instant>("kotlinx.datetime.Instant", Json.serializersModule.serializer())
         iso8601Serialization(Json.serializersModule.serializer())
     }
 
diff --git a/serialization/common/test/LocalDateSerializationTest.kt b/serialization/common/test/LocalDateSerializationTest.kt
@@ -56,17 +56,20 @@ class LocalDateSerializationTest {
 
     @Test
     fun testIso8601Serialization() {
+        assertKSerializerName("kotlinx.datetime.LocalDate", LocalDateIso8601Serializer)
         iso8601Serialization(LocalDateIso8601Serializer)
     }
 
     @Test
     fun testComponentSerialization() {
+        assertKSerializerName("kotlinx.datetime.LocalDate", LocalDateComponentSerializer)
         componentSerialization(LocalDateComponentSerializer)
     }
 
     @Test
     fun testDefaultSerializers() {
         // should be the same as the ISO 8601
+        assertKSerializerName<LocalDate>("kotlinx.datetime.LocalDate", Json.serializersModule.serializer())
         iso8601Serialization(Json.serializersModule.serializer())
     }
 
diff --git a/serialization/common/test/LocalDateTimeSerializationTest.kt b/serialization/common/test/LocalDateTimeSerializationTest.kt
@@ -70,17 +70,20 @@ class LocalDateTimeSerializationTest {
 
     @Test
     fun testIso8601Serialization() {
+        assertKSerializerName<LocalDateTime>("kotlinx.datetime.LocalDateTime", LocalDateTimeComponentSerializer)
         iso8601Serialization(LocalDateTimeIso8601Serializer)
     }
 
     @Test
     fun testComponentSerialization() {
+        assertKSerializerName<LocalDateTime>("kotlinx.datetime.LocalDateTime", LocalDateTimeComponentSerializer)
         componentSerialization(LocalDateTimeComponentSerializer)
     }
 
     @Test
     fun testDefaultSerializers() {
         // should be the same as the ISO 8601
+        assertKSerializerName<LocalDateTime>("kotlinx.datetime.LocalDateTime", Json.serializersModule.serializer())
         iso8601Serialization(Json.serializersModule.serializer())
     }
 
diff --git a/serialization/common/test/LocalTimeSerializationTest.kt b/serialization/common/test/LocalTimeSerializationTest.kt
@@ -60,17 +60,20 @@ class LocalTimeSerializationTest {
 
     @Test
     fun testIso8601Serialization() {
+        assertKSerializerName("kotlinx.datetime.LocalTime", LocalTimeIso8601Serializer)
         iso8601Serialization(LocalTimeIso8601Serializer)
     }
 
     @Test
     fun testComponentSerialization() {
+        assertKSerializerName("kotlinx.datetime.LocalTime", LocalTimeComponentSerializer)
         componentSerialization(LocalTimeComponentSerializer)
     }
 
     @Test
     fun testDefaultSerializers() {
         // should be the same as the ISO 8601
+        assertKSerializerName<LocalTime>("kotlinx.datetime.LocalTime", Json.serializersModule.serializer())
         iso8601Serialization(Json.serializersModule.serializer())
     }
 
diff --git a/serialization/common/test/MonthSerializationTest.kt b/serialization/common/test/MonthSerializationTest.kt
@@ -13,10 +13,11 @@ import kotlin.test.*
 class MonthSerializationTest {
     @Test
     fun testSerialization() {
+        assertKSerializerName("kotlinx.datetime.Month", MonthSerializer)
         for (month in Month.entries) {
             val json = "\"${month.name}\""
             assertEquals(json, Json.encodeToString(MonthSerializer, month))
             assertEquals(month, Json.decodeFromString(MonthSerializer, json))
         }
     }
-}
+}
diff --git a/serialization/common/test/TimeZoneSerializationTest.kt b/serialization/common/test/TimeZoneSerializationTest.kt
@@ -46,7 +46,11 @@ class TimeZoneSerializationTest {
 
     @Test
     fun testDefaultSerializers() {
+        assertKSerializerName<FixedOffsetTimeZone>(
+            "kotlinx.datetime.FixedOffsetTimeZone", Json.serializersModule.serializer()
+        )
         zoneOffsetSerialization(Json.serializersModule.serializer())
+        assertKSerializerName<TimeZone>("kotlinx.datetime.TimeZone", Json.serializersModule.serializer())
         serialization(Json.serializersModule.serializer())
     }
-}
+}
diff --git a/serialization/common/test/UtcOffsetSerializationTest.kt b/serialization/common/test/UtcOffsetSerializationTest.kt
@@ -27,11 +27,13 @@ class UtcOffsetSerializationTest {
 
     @Test
     fun defaultSerializer() {
+        assertKSerializerName<UtcOffset>("kotlinx.datetime.UtcOffset", Json.serializersModule.serializer())
         testSerializationAsPrimitive(Json.serializersModule.serializer())
     }
 
     @Test
     fun stringPrimitiveSerializer() {
+        assertKSerializerName("kotlinx.datetime.UtcOffset", UtcOffsetSerializer)
         testSerializationAsPrimitive(UtcOffsetSerializer)
         testSerializationAsPrimitive(UtcOffset.serializer())
     }

Original file line number	Diff line number	Diff line change
`@@ -97,28 +97,34 @@ class DateTimePeriodSerializationTest {`
`97`	`97`
`98`	`98`	`@Test`
`99`	`99`	`fun testDatePeriodIso8601Serialization() {`
	`100`	`+ assertKSerializerName("kotlinx.datetime.DatePeriod", DatePeriodIso8601Serializer)`
`100`	`101`	`datePeriodIso8601Serialization(DatePeriodIso8601Serializer, DateTimePeriodIso8601Serializer)`
`101`	`102`	`}`
`102`	`103`
`103`	`104`	`@Test`
`104`	`105`	`fun testDatePeriodComponentSerialization() {`
	`106`	`+ assertKSerializerName("kotlinx.datetime.DatePeriod", DatePeriodComponentSerializer)`
`105`	`107`	`datePeriodComponentSerialization(DatePeriodComponentSerializer, DateTimePeriodComponentSerializer)`
`106`	`108`	`}`
`107`	`109`
`108`	`110`	`@Test`
`109`	`111`	`fun testDateTimePeriodIso8601Serialization() {`
	`112`	`+ assertKSerializerName("kotlinx.datetime.DateTimePeriod", DateTimePeriodIso8601Serializer)`
`110`	`113`	`dateTimePeriodIso8601Serialization(DateTimePeriodIso8601Serializer)`
`111`	`114`	`}`
`112`	`115`
`113`	`116`	`@Test`
`114`	`117`	`fun testDateTimePeriodComponentSerialization() {`
	`118`	`+ assertKSerializerName("kotlinx.datetime.DateTimePeriod", DateTimePeriodComponentSerializer)`
`115`	`119`	`dateTimePeriodComponentSerialization(DateTimePeriodComponentSerializer)`
`116`	`120`	`}`
`117`	`121`
`118`	`122`	`@Test`
`119`	`123`	`fun testDefaultSerializers() {`
`120`	`124`	`// Check that they behave the same as the ISO 8601 serializers`
	`125`	`+ assertKSerializerName<DateTimePeriod>("kotlinx.datetime.DateTimePeriod", Json.serializersModule.serializer())`
`121`	`126`	`dateTimePeriodIso8601Serialization(Json.serializersModule.serializer())`
	`127`	`+ assertKSerializerName<DatePeriod>("kotlinx.datetime.DatePeriod", Json.serializersModule.serializer())`
`122`	`128`	`datePeriodIso8601Serialization(Json.serializersModule.serializer(), Json.serializersModule.serializer())`
`123`	`129`	`}`
`124`	`130`
Original file line number	Diff line number	Diff line change
`@@ -13,10 +13,11 @@ import kotlin.test.*`
`13`	`13`	`class DayOfWeekSerializationTest {`
`14`	`14`	`@Test`
`15`	`15`	`fun testSerialization() {`
	`16`	`+ assertKSerializerName("kotlinx.datetime.DayOfWeek", DayOfWeekSerializer)`
`16`	`17`	`for (dayOfWeek in DayOfWeek.entries) {`
`17`	`18`	`val json = "\"${dayOfWeek.name}\""`
`18`	`19`	`assertEquals(json, Json.encodeToString(DayOfWeekSerializer, dayOfWeek))`
`19`	`20`	`assertEquals(dayOfWeek, Json.decodeFromString(DayOfWeekSerializer, json))`
`20`	`21`	`}`
`21`	`22`	`}`
`22`		`-}`
	`23`	`+}`
Original file line number	Diff line number	Diff line change
`@@ -54,17 +54,20 @@ class InstantSerializationTest {`
`54`	`54`
`55`	`55`	`@Test`
`56`	`56`	`fun testIso8601Serialization() {`
	`57`	`+ assertKSerializerName("kotlinx.datetime.Instant", InstantIso8601Serializer)`
`57`	`58`	`iso8601Serialization(InstantIso8601Serializer)`
`58`	`59`	`}`
`59`	`60`
`60`	`61`	`@Test`
`61`	`62`	`fun testComponentSerialization() {`
	`63`	`+ assertKSerializerName("kotlinx.datetime.Instant", InstantComponentSerializer)`
`62`	`64`	`componentSerialization(InstantComponentSerializer)`
`63`	`65`	`}`
`64`	`66`
`65`	`67`	`@Test`
`66`	`68`	`fun testDefaultSerializers() {`
`67`	`69`	`// should be the same as the ISO 8601`
	`70`	`+ assertKSerializerName<Instant>("kotlinx.datetime.Instant", Json.serializersModule.serializer())`
`68`	`71`	`iso8601Serialization(Json.serializersModule.serializer())`
`69`	`72`	`}`
`70`	`73`
Original file line number	Diff line number	Diff line change
`@@ -56,17 +56,20 @@ class LocalDateSerializationTest {`
`56`	`56`
`57`	`57`	`@Test`
`58`	`58`	`fun testIso8601Serialization() {`
	`59`	`+ assertKSerializerName("kotlinx.datetime.LocalDate", LocalDateIso8601Serializer)`
`59`	`60`	`iso8601Serialization(LocalDateIso8601Serializer)`
`60`	`61`	`}`
`61`	`62`
`62`	`63`	`@Test`
`63`	`64`	`fun testComponentSerialization() {`
	`65`	`+ assertKSerializerName("kotlinx.datetime.LocalDate", LocalDateComponentSerializer)`
`64`	`66`	`componentSerialization(LocalDateComponentSerializer)`
`65`	`67`	`}`
`66`	`68`
`67`	`69`	`@Test`
`68`	`70`	`fun testDefaultSerializers() {`
`69`	`71`	`// should be the same as the ISO 8601`
	`72`	`+ assertKSerializerName<LocalDate>("kotlinx.datetime.LocalDate", Json.serializersModule.serializer())`
`70`	`73`	`iso8601Serialization(Json.serializersModule.serializer())`
`71`	`74`	`}`
`72`	`75`
Original file line number	Diff line number	Diff line change
`@@ -70,17 +70,20 @@ class LocalDateTimeSerializationTest {`
`70`	`70`
`71`	`71`	`@Test`
`72`	`72`	`fun testIso8601Serialization() {`
	`73`	`+ assertKSerializerName<LocalDateTime>("kotlinx.datetime.LocalDateTime", LocalDateTimeComponentSerializer)`
`73`	`74`	`iso8601Serialization(LocalDateTimeIso8601Serializer)`
`74`	`75`	`}`
`75`	`76`
`76`	`77`	`@Test`
`77`	`78`	`fun testComponentSerialization() {`
	`79`	`+ assertKSerializerName<LocalDateTime>("kotlinx.datetime.LocalDateTime", LocalDateTimeComponentSerializer)`
`78`	`80`	`componentSerialization(LocalDateTimeComponentSerializer)`
`79`	`81`	`}`
`80`	`82`
`81`	`83`	`@Test`
`82`	`84`	`fun testDefaultSerializers() {`
`83`	`85`	`// should be the same as the ISO 8601`
	`86`	`+ assertKSerializerName<LocalDateTime>("kotlinx.datetime.LocalDateTime", Json.serializersModule.serializer())`
`84`	`87`	`iso8601Serialization(Json.serializersModule.serializer())`
`85`	`88`	`}`
`86`	`89`
Original file line number	Diff line number	Diff line change
`@@ -60,17 +60,20 @@ class LocalTimeSerializationTest {`
`60`	`60`
`61`	`61`	`@Test`
`62`	`62`	`fun testIso8601Serialization() {`
	`63`	`+ assertKSerializerName("kotlinx.datetime.LocalTime", LocalTimeIso8601Serializer)`
`63`	`64`	`iso8601Serialization(LocalTimeIso8601Serializer)`
`64`	`65`	`}`
`65`	`66`
`66`	`67`	`@Test`
`67`	`68`	`fun testComponentSerialization() {`
	`69`	`+ assertKSerializerName("kotlinx.datetime.LocalTime", LocalTimeComponentSerializer)`
`68`	`70`	`componentSerialization(LocalTimeComponentSerializer)`
`69`	`71`	`}`
`70`	`72`
`71`	`73`	`@Test`
`72`	`74`	`fun testDefaultSerializers() {`
`73`	`75`	`// should be the same as the ISO 8601`
	`76`	`+ assertKSerializerName<LocalTime>("kotlinx.datetime.LocalTime", Json.serializersModule.serializer())`
`74`	`77`	`iso8601Serialization(Json.serializersModule.serializer())`
`75`	`78`	`}`
`76`	`79`
Original file line number	Diff line number	Diff line change
`@@ -27,11 +27,13 @@ class UtcOffsetSerializationTest {`
`27`	`27`
`28`	`28`	`@Test`
`29`	`29`	`fun defaultSerializer() {`
	`30`	`+ assertKSerializerName<UtcOffset>("kotlinx.datetime.UtcOffset", Json.serializersModule.serializer())`
`30`	`31`	`testSerializationAsPrimitive(Json.serializersModule.serializer())`
`31`	`32`	`}`
`32`	`33`
`33`	`34`	`@Test`
`34`	`35`	`fun stringPrimitiveSerializer() {`
	`36`	`+ assertKSerializerName("kotlinx.datetime.UtcOffset", UtcOffsetSerializer)`
`35`	`37`	`testSerializationAsPrimitive(UtcOffsetSerializer)`
`36`	`38`	`testSerializationAsPrimitive(UtcOffset.serializer())`
`37`	`39`	`}`