built out rough input parser taking basic yes no commands, as well as… #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the command move
|
This is a start to the issue for #3 . I felt that by bringing in a starting place for I/O, it might help get the juices flowing for everyone. Feel free to change the implementation. This is certainly incomplete. |
| pub static VALID_NEGATIVE_RESPONSES: [&str; 2] = ["no", "n"]; | ||
| static VALID_ACTIONS: [&str; 1] = ["move"]; | ||
|
|
||
| pub fn get_valid_response(input: String) -> (String, bool) { |
There was a problem hiding this comment.
These are awesome helper funcs, I like the way it's organized
| mod story_manager; | ||
| use story_manager::{introduction, tutorial}; | ||
| mod user_command; | ||
|
|
||
| fn main() { |
There was a problem hiding this comment.
I love how this is organized and modular too 👌
mikelbrierly
approved these changes
Aug 22, 2022
|
|
||
| let mut buffer = String::with_capacity(2048); | ||
| // Lock our standard input to eliminate synchronization overhead (unlocks when dropped) | ||
| let mut stdin = io::stdin().lock(); |
There was a problem hiding this comment.
I'm curious about this, and maybe I just haven't learned enough about Rust yet, but -
line 40 defines an immutable variable, right? but then line 44 defines the same variable name, but mutable, so is this still a "shadow" variable since the first one was supposed to be immutable?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… the command move