Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cumulative percent mode to contribution analysis #1431

Open
3 tasks
marc-vdm opened this issue Jan 15, 2025 · 0 comments · May be fixed by #1433
Open
3 tasks

Add cumulative percent mode to contribution analysis #1431

marc-vdm opened this issue Jan 15, 2025 · 0 comments · May be fixed by #1433
Assignees
Labels
feature Issues/PRs related to a new feature

Comments

@marc-vdm
Copy link
Member

Feature request

Can be implemented after #1430

AB currently has 2 cut-off modes, another should be added.

  • refactor Relative mode to Percent
  • add option for Cumulative Percent
  • Set default percentage for this mode to 80%

Most UI work can be re-used probably, the contribution code is also already written and ready to go, we just need to call ca.sort_array with limit_type = cum_percent for this mode.

@marc-vdm marc-vdm added the feature Issues/PRs related to a new feature label Jan 15, 2025
@marc-vdm marc-vdm self-assigned this Jan 15, 2025
@marc-vdm marc-vdm linked a pull request Jan 16, 2025 that will close this issue
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Issues/PRs related to a new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant