You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
Currently, we have a config directory with JSON configs in it. This is slightly ugly.
Because of the long-running nature of this system, I think having a file-based config is good for everyone, but perhaps just having a single file, and having the LIBREary base class instantiate each of the subclasses it needs with class-based configs would be better.
Describe the solution you'd like
LIBREary would have a single config, then, within the file, it would do things like this: adapterman = AdapterManager(levels=[self.config.levels])
rather than this: adapterman = AdapterManager(config_dir="CONFIG")
Describe alternatives you've considered
This is a proposal of an alternative
The text was updated successfully, but these errors were encountered:
I think this will definitely be the right way to go so that we can pass around objects (the metadata manager is the first big reason). For now, I'm going to keep the same config structure, but also pass the metadata manager around. This big change is sort of low-priority though.
Is your feature request related to a problem? Please describe.
Currently, we have a config directory with JSON configs in it. This is slightly ugly.
Because of the long-running nature of this system, I think having a file-based config is good for everyone, but perhaps just having a single file, and having the LIBREary base class instantiate each of the subclasses it needs with class-based configs would be better.
Describe the solution you'd like
LIBREary would have a single config, then, within the file, it would do things like this:
adapterman = AdapterManager(levels=[self.config.levels])
rather than this:
adapterman = AdapterManager(config_dir="CONFIG")
Describe alternatives you've considered
This is a proposal of an alternative
The text was updated successfully, but these errors were encountered: