Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(up for debate) class-based configs of some kind #48

Open
benhg opened this issue Jan 23, 2020 · 2 comments
Open

(up for debate) class-based configs of some kind #48

benhg opened this issue Jan 23, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@benhg
Copy link
Member

benhg commented Jan 23, 2020

Is your feature request related to a problem? Please describe.
Currently, we have a config directory with JSON configs in it. This is slightly ugly.

Because of the long-running nature of this system, I think having a file-based config is good for everyone, but perhaps just having a single file, and having the LIBREary base class instantiate each of the subclasses it needs with class-based configs would be better.

Describe the solution you'd like
LIBREary would have a single config, then, within the file, it would do things like this:
adapterman = AdapterManager(levels=[self.config.levels])
rather than this:
adapterman = AdapterManager(config_dir="CONFIG")

Describe alternatives you've considered
This is a proposal of an alternative

@benhg benhg added the enhancement New feature or request label Jan 23, 2020
@benhg benhg assigned benhg and unassigned benhg Jan 23, 2020
@benhg
Copy link
Member Author

benhg commented Jan 23, 2020

I'm not going to milestone this, as I'm not certain whether it's the right idea.

@benhg
Copy link
Member Author

benhg commented Jan 24, 2020

I think this will definitely be the right way to go so that we can pass around objects (the metadata manager is the first big reason). For now, I'm going to keep the same config structure, but also pass the metadata manager around. This big change is sort of low-priority though.

@benhg benhg added this to the 0.0.3 milestone Feb 1, 2020
@benhg benhg removed this from the 0.0.3 milestone Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant