Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow individual tours location for the chrome extension #58

Open
eeddaann opened this issue Nov 14, 2020 · 4 comments
Open

Allow individual tours location for the chrome extension #58

eeddaann opened this issue Nov 14, 2020 · 4 comments

Comments

@eeddaann
Copy link

First of all the idea of making the chrome extension is brilliant!
However it would be better if you could host the tours on your own and don't be dependent on third party...
I have tried to unpack the extension and "hack" it to look for "tours" definitions in a different URL then the hardcoded one...
it worked but it would be better if you could add the source code for the extension :)

@r-brown
Copy link
Member

r-brown commented Nov 15, 2020

Hello @eeddaann thank you for your interest to GuideChimp Chrome Extension!

As of now we do no plan do disclose extension source code.
However, we plan to extend functionality here; e.g. individual enabling of GuideChimp plugins as well as individual tours location.

@r-brown
Copy link
Member

r-brown commented Nov 15, 2020

As of now we plan to keep the tours in one central tours repository, so these are available for the GuideChimp community.

@r-brown r-brown changed the title Add source code for the chrome extension Allow indiavidual tours location for the chrome extension Nov 15, 2020
@eeddaann
Copy link
Author

Thanks for the fast response!
a possible implementation may based on this example

I really liked your idea of putting the configs in github since it's makes the tours versioned out-of-the-box.
however I've noticed that the extension looks for the tours at: https://www.labs64.com/guidechimp/tours and not on github.

In addition we should think about the Content Security Policy (CSP) at the manifest of the extension, the current manifest references to your site:
"content_security_policy": "default-src 'self'; connect-src https://www.labs64.com"
however if the user will be able to set another tour location, it should be aligned with the policy.

hope this comment was helpful :)

@r-brown
Copy link
Member

r-brown commented Nov 15, 2020

...I've noticed that the extension looks for the tours at: https://www.labs64.com/guidechimp/tours and not on github.

Path https://www.labs64.com/guidechimp/tours is the forward for https://github.com/Labs64/GuideChimp-tours/tree/master/guidechimp/tours
So, every public tour at GitHub will be resolved as well; e.g.
https://github.com/Labs64/GuideChimp-tours/tree/master/guidechimp/tours/netlicensing.io.json
https://www.labs64.com/guidechimp/tours/netlicensing.io.json

@r-brown r-brown changed the title Allow indiavidual tours location for the chrome extension Allow individual tours location for the chrome extension Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants