Skip to content
This repository has been archived by the owner on Feb 1, 2021. It is now read-only.

Expecto "spirit emoji" are not updated #6

Open
pblasucci opened this issue Mar 29, 2018 · 5 comments
Open

Expecto "spirit emoji" are not updated #6

pblasucci opened this issue Mar 29, 2018 · 5 comments
Labels
Expecto Problems and suggestions related to Expecto Test detection Problems are suggestions related to test detection UX Problems and suggestions related to UI/UX
Milestone

Comments

@pblasucci
Copy link

pblasucci commented Mar 29, 2018

Test cases which contain "spriti emoji" fail to have their state updated (i.e. icon colors don't change, test explorer doesn't recategorize)

  • Work-around: don't use stupid "spirit emoji" in test case names
  • Platform: Windows 10
  • Runtime: .NET Core 2.1

Minimal reproduction: https://github.com/pblasucci/neptune_expecto_repro

@Krzysztof-Cieslak
Copy link
Member

This is probably happening not only with "spriti emoji", but also with any test name using special UTF8 characters.

I don't see easy way to solve it at the moment, and I don't feel it's super critical issue - I will put it into backlog

@pblasucci
Copy link
Author

Thanks! And agree. This really isn’t a big deal.

@Krzysztof-Cieslak Krzysztof-Cieslak added this to the Backlog milestone Mar 29, 2018
@Krzysztof-Cieslak Krzysztof-Cieslak added Test detection Problems are suggestions related to test detection UX Problems and suggestions related to UI/UX labels Mar 29, 2018
@Krzysztof-Cieslak
Copy link
Member

Funny fact - it works fine for me on Linux. I wonder if it has something to do with terminal encoding etc.

screenshot from 2018-04-01 19 38 36

@pblasucci
Copy link
Author

Weird! I suspect you might be right.

Still not something to lose sleep over, though.

:-)

@AkosLukacs
Copy link

Looks like not just special UTF8 characters, but any non-ascii character in test names breaks the integration. For example "á", "é" are not that extreme characters, and usually work everywhere.

It's definitely some kind of character encoding issue, because if I look at Neptune Expecto output, I see this (notice the "�" in the output):

[11:43:55 INF] EXPECTO?! Summary...
Passed:  2
	samples/Should work [c:\Dev\ExpectoSample\Sample.fs:10]
	samples/Not really extr�m character should work [c:\Dev\ExpectoSample\Sample.fs:18]
Ignored: 0
	Failed:  2
	samples/Should fail [c:\Dev\ExpectoSample\Sample.fs:14]
	samples/Not really extr�m character should fail [c:\Dev\ExpectoSample\Sample.fs:22]
Errored: 0
	 <Expecto>

But if I run it from console dotnet run -- --debug --summary-location, the output is ok:

[11:54:36 INF] EXPECTO?! Summary...
Passed:  2
        samples/Should work [C:\Dev\ExpectoSample\Sample.fs:10]
        samples/Not really extrém character should work [C:\Dev\ExpectoSample\Sample.fs:18]
Ignored: 0
        Failed:  2
        samples/Should fail [C:\Dev\ExpectoSample\Sample.fs:14]
        samples/Not really extrém character should fail [C:\Dev\ExpectoSample\Sample.fs:22]
Errored: 0
         <Expecto>

Repro: just add these tests to the sample by @pblasucci, I'm on Win10 and .NET Core 2.1 as well

    test "Not really extrém character should work" {
      Expect.equal true true "This should work"
    }

    test "Not really extrém character should fail" {
      Expect.equal true false "This should not work"
    }

@Krzysztof-Cieslak Krzysztof-Cieslak added the Expecto Problems and suggestions related to Expecto label Apr 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Expecto Problems and suggestions related to Expecto Test detection Problems are suggestions related to test detection UX Problems and suggestions related to UI/UX
Projects
None yet
Development

No branches or pull requests

3 participants