Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binary format save files #22

Open
Lamby777 opened this issue Sep 20, 2023 · 2 comments
Open

Binary format save files #22

Lamby777 opened this issue Sep 20, 2023 · 2 comments
Labels
dev-interface Things only developers care about (refactoring, schema changes, etc.) enhancement New feature or request rust GDExtension Rust-related stuff

Comments

@Lamby777
Copy link
Owner

This is more of a long-term thing, but save files should be saved/loaded with a binary format to be more efficient. For now, though, they're gonna be JSON or some other human-readable format for easier debugging.

@Lamby777 Lamby777 added enhancement New feature or request rust GDExtension Rust-related stuff dev-interface Things only developers care about (refactoring, schema changes, etc.) labels Sep 20, 2023
@Lamby777 Lamby777 added this to the Core Functionality Complete milestone Sep 20, 2023
@Lamby777
Copy link
Owner Author

Lamby777 commented Jun 9, 2024

For what it's worth, this also exists for player settings: https://docs.godotengine.org/en/stable/classes/class_configfile.html#class-configfile

So you can separate settings from your save file...

Probably gonna use bincode for serialization just like I did for dg, and then use godot methods to write it to a file. That is, unless I want to support future versions. Probably gonna stick to JSON for a while into development actually, just so old save files continue to somewhat work in new versions.

@Lamby777
Copy link
Owner Author

Lamby777 commented Jun 9, 2024

Yeet.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev-interface Things only developers care about (refactoring, schema changes, etc.) enhancement New feature or request rust GDExtension Rust-related stuff
Projects
None yet
Development

No branches or pull requests

1 participant