Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sprockets conflict with embedded_svg helper #39

Open
reubenbrown opened this issue Apr 4, 2016 · 1 comment
Open

Sprockets conflict with embedded_svg helper #39

reubenbrown opened this issue Apr 4, 2016 · 1 comment

Comments

@reubenbrown
Copy link
Contributor

When using the sprockets-rails gem version 3.0.0 or above and have Rails.application.config.assets.compile set to false the embedded_svg helper will fail because Rails.application.assets will return nil and therefore can't find the asset.

There are a bunch of different ways to handle this. Personally I used a modified version of the code provided here to get around this issue and return the proper filepath to be opened. But I guess since this helper method is only being used for alert-icon.svg it might be easier to just get rid of the helper method altogether?

@francirp
Copy link
Contributor

👍 probably a good idea @reubenbrown. I'll try to put together a PR and run it your way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants