Chore: Package updates #49
Conversation
| @@ -12,8 +12,7 @@ | |||
| "prepublish": "yarn run lint && yarn run clean && yarn run build", | |||
| "test": "jest", | |||
| "size": "yarn build && size-limit", | |||
| "test:coverage": "jest --coverage", | |||
| "report-coverage": "codeclimate-test-reporter < coverage/lcov.info" | |||
There was a problem hiding this comment.
This command doesn't work on main currently and it might never have worked. The package itself has been deprecated. Given that it's not used by anything, I'd rather remove it then "fix" it.
| "@size-limit/file": "^8.2.6", | ||
| "@size-limit/webpack": "^8.2.6", |
There was a problem hiding this comment.
@size-limit switched from defaulting to webpack in v6 to esbuild in v7/v8. For some reason, this caused our reported build size to nearly quadruple (8.63 kb -> 31.05 kb). I tried to dig into what was going on, but I wasn't able to make much progress.
Given that webpack is what we were using to determine the size, this feels like less of a breaking change (despite the swap out in packages) and intuitively makes more sense.
| @@ -21,31 +21,31 @@ test('flashMessage sets default timeout if none is provided', () => { | |||
| const store = createMockStore() | |||
| store.dispatch(flashMessage('Hi')) | |||
| expect(store.getActionTypes()).toEqual([ADD_MESSAGE_ACTION_TYPE]) | |||
| jest.runTimersToTime(4000) | |||
There was a problem hiding this comment.
This method was deprecated
| @@ -5,6 +5,8 @@ import { | |||
| } from '../src' | |||
| import { createMockStore } from './helpers' | |||
|
|
|||
| jest.useFakeTimers() | |||
There was a problem hiding this comment.
Without this, jest was reporting a potential unhandled operation (as a result of setTimeout in middleware.js)
There was a problem hiding this comment.
Wow. I'm sure that was fun to figure out.
Resolves #45
Resolves #39 (except for
redux-actions)I didn't update
redux-actionsto v3 because they switched to ESM only, which our current Jest configuration doesn't understand. I honestly can't be fussed to dig into it further at the minute given how much of a headache ESM/CJS has become.