Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent names for sidechain IDs #10

Open
torkelrogstad opened this issue Oct 14, 2024 · 1 comment
Open

Inconsistent names for sidechain IDs #10

torkelrogstad opened this issue Oct 14, 2024 · 1 comment
Labels
refactor

Comments

@torkelrogstad
Copy link
Contributor

We're using sidechain_number and sidechain_id apparently nilly-willy.

I've found sidechain_number in different requests in validator.proto:

  1. GetCoinbasePSBTRequest
  2. AckSidechain
  3. ProposeBundle
  4. GetCtipRequest
  5. GetSidechainProposalsResponse.SidechainProposal
  6. GetSidechainsResponse.SidechainInfo

Whereas sidechain_id is found in:

  1. validator.proto
    1. GetBlockInfoRequest
    2. GetBmmHStarCommitmentRequest
    3. GetTwoWayPegDataRequest
    4. SubscribeEventsRequest
  2. wallet.proto
    1. BroadcastWithdrawalBundleRequest
    2. CreateBmmCriticalDataTransactionRequest
    3. CreateDepositTransactionRequest

I think it'd be a good idea to be consistent in what we're using. Personally I think I prefer sidechain_id.
@octobocto
Copy link
Contributor

My preference is sidechain_slot, or just slot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nchashch @torkelrogstad @octobocto