Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to connect to ipv4 peers, stuck in bad retrying state #14

Open
torkelrogstad opened this issue Jan 23, 2025 · 0 comments
Open

Unable to connect to ipv4 peers, stuck in bad retrying state #14

torkelrogstad opened this issue Jan 23, 2025 · 0 comments

Comments

@torkelrogstad
Copy link
Contributor

There are actually several issues here. Follow along through this list of actions, and I'll point them out.

  1. Run two instances of Thunder, one at 0.0.0.0:4009 and one at 0.0.0.0:4008
  2. Connect 4009 to 4008: cargo run --bin thunder_app_cli -- connect-peer 0.0.0.0:4008. This command outputs nothing, indicating that this succeeded. However, immediately after we receive a quinn::ConnectError::InvalidRemoteAddress in the mailbox. It's unfortunate that this error is not propagated out to the CLI. We should somehow wait for the connection to be established before returning
  3. Restart the first instance. Observe in the logs that we're trying to reconnect to 0.0.0.0:4008, receiving the same errors. If we're running into InvalidRemoteAddress, the peer should be removed from the list of peers we're trying to connect to on startup
  4. Retry the connection attempt. Observe that there's no output from the CLI. I'd expect output here, saying that the peer is already added

From what I can gather, InvalidRemoteAddress can hit in one of two places

  1. https://github.com/quinn-rs/quinn/blob/2125b36a1470f4fc498c68ef76ec955f4ff0d210/quinn-proto/src/endpoint.rs#L330-L332
  2. https://github.com/quinn-rs/quinn/blob/2125b36a1470f4fc498c68ef76ec955f4ff0d210/quinn/src/endpoint.rs#L214-L216
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant