New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

suggestion: limit domains input array #34

Open

andrzej-woof opened this issue Nov 18, 2022 · 0 comments

andrzej-woof commented Nov 18, 2022

I've bumped into an issue providing long list of domains to to getDnsRecords on OSX:

when full cmd to be executed is somewhere between 568263 and 568443 characters long it fails with /bin/sh: /usr/bin/dig: Argument list too long
for much longer list of arguments it fails with Error: spawn E2BIG

it's going to be of course system dependent value but maybe worth putting in some limits?
Suggestions:

limit domains input to some arbitrary number (1k domains?) and reject with meaningful error message
limit command string length and reject with meaningful error message
implement chunking for larger arrays (with parallel resolve)

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment