Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Missing parameter in _verifyContractsInitialized() call #950

Open
pablodeymo opened this issue Dec 12, 2024 · 0 comments
Open

Bug: Missing parameter in _verifyContractsInitialized() call #950

pablodeymo opened this issue Dec 12, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@pablodeymo
Copy link

In the mainnet branch, the new version of the function _verifyContractsInitialized receives a parameters that wasn't receiving in previous versions.

function _verifyContractsInitialized(bool /** isInitialDeployment **/)

The file script/deploy/holesky/upgrade_preprod_rewardsCoordinator.s.sol has a call to that function without the parameter in the line 40, so the compilation of this file is giving an error: _verifyContractsInitialized();

To Reproduce
Steps to reproduce the behavior:

  1. In the mainnet branch, in the root of the repo, run the command: forge build

You will get:

[⠒] Compiling...
[⠔] Compiling 1 files with Solc 0.8.12
[⠒] Solc 0.8.12 finished in 313.27ms
Error: 
Compiler run failed:
Error (6160): Wrong argument count for function call: 0 arguments given but expected 1.
  --> script/deploy/holesky/upgrade_preprod_rewardsCoordinator.s.sol:40:9:
   |
40 |         _verifyContractsInitialized();
   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Environment
Enter important environment info needed to reproduce the bug.

  • [e.g. chrome, safari]
  • [e.g. version]

Don't Forget To

  • Assign this to a project (our default is eigenlayer)
  • Add priority + size estimate
  • Set status to New
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant