Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Old deals still showing up on "All Deals" page #257

Open
ryandotfurrer opened this issue Aug 29, 2024 · 1 comment
Open

[BUG]: Old deals still showing up on "All Deals" page #257

ryandotfurrer opened this issue Aug 29, 2024 · 1 comment
Labels
🚀 Enhancement Suggesting improvements to existing features.

Comments

@ryandotfurrer
Copy link
Collaborator

ryandotfurrer commented Aug 29, 2024

Describe the bug
Deals that have expired are still showing up on the "All Deals" page.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'homepage'
  2. Click on 'shop all deals'
  3. Scroll down to see expired deals still being rendered (such as THAT WI ticket)

Expected behavior
I'd expect the old deals to not be shown on the website once the current date is past their end date.

Screenshots
Screenshot_20240829-092103.png

Screenshot_20240829-091743.png

Desktop (please complete the following information):
N/A - issue with db query.

Smartphone (please complete the following information):
N/A - issue with db query.

Suggested Solution
Update query used on "all deals" page to omit entries with an end date older than current date

@ryandotfurrer ryandotfurrer added the 🚀 Enhancement Suggesting improvements to existing features. label Aug 29, 2024
@mibijoy007
Copy link
Contributor

Please take a look @ryandotfurrer @jamesqquick

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚀 Enhancement Suggesting improvements to existing features.
Projects
Status: No status
Development

No branches or pull requests

2 participants