Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/MIDAZ-358 #376

Merged
merged 19 commits into from
Dec 12, 2024
Merged

Feature/MIDAZ-358 #376

merged 19 commits into from
Dec 12, 2024

Conversation

qnen
Copy link
Contributor

@qnen qnen commented Dec 11, 2024 •
edited
Loading

Midaz Pull Request Checklist

Pull Request Type

  • Auth
  • Infra
  • Ledger
  • Mdz
  • Transaction
  • Pipeline
  • Documentation

Checklist

Please check each item after it's completed.

  • I have tested these changes locally.
  • I have updated the documentation accordingly.
  • I have added necessary comments to the code, especially in complex areas.
  • I have ensured that my changes adhere to the project's coding standards.
  • I have checked for any potential security issues.
  • I have ensured that all tests pass.
  • I have updated the version appropriately (if applicable).
  • I have confirmed this code is ready for review.

Additional Notes

Obs: Please, always remember to target your PR to develop branch instead of main.

qnen added 10 commits December 9, 2024 23:55
@qnen
feat(pagination): add sort order filter and date ranges to the midaz …
4cc01d3 
…pagination filtering ✨
@qnen
feat(tests): update tests with to pagination filter struct ✨
793b685
@qnen
chore: fix small indentation and temp variable issues 🔧
87e19b6
@qnen
feat(asset-rate): add cursor pagination to get all entities endpoint ✨
441c51c
@qnen
refactor(pagination): update all services to use the modularized pagi…
f4e8a45 
…nation by cursor or offset 🔨
@qnen
feat(operation): add cursor pagination to get all entities endpoints ✨
21315a3
@qnen
feat(transaction): add cursor pagination to get all entities endpoint ✨
9b1cb94
@qnen
Merge branch 'develop' into feature/MIDAZ-358
355c471
@qnen
docs(pagination): add pagination fields to swagger documentations 📚
0a79234
@qnen
feat(postman): add pagination fields to postman for get all endpoints ✨
63e3e56
@qnen qnen added feature New feature domain:onboarding Responsible for the initial configuration of the ledger domain:portfolio Responsible for creating accounts domain:transactions Responsible for transactions and operations labels Dec 11, 2024
@qnen qnen self-assigned this Dec 11, 2024
@qnen qnen requested a review from a team as a code owner December 11, 2024 23:55
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 11, 2024
View reviewed changes
pkg/net/http/httputils.go Fixed Show fixed Hide fixed
pkg/net/http/httputils.go Fixed Show fixed Hide fixed
pkg/net/http/httputils.go Fixed Show fixed Hide fixed
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 12, 2024
View reviewed changes
pkg/utils.go Fixed Show resolved Hide resolved
qnen and others added 2 commits December 11, 2024 21:28
@qnen
test(pkg): add cursor utils unit tests 🚨
01a1247
@qnen @github-advanced-security
Fix code scanning alert no. 5: Incorrect conversion between integer t…
1bffb6b 
…ypes

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
@qnen qnen linked an issue Dec 12, 2024 that may be closed by this pull request
Implement pagination rules #358
Closed
lerian-studio-midaz-push-bot[bot]
lerian-studio-midaz-push-bot bot reviewed Dec 12, 2024
View reviewed changes
Copy link

@lerian-studio-midaz-push-bot lerian-studio-midaz-push-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

golint

🚫 [golint] reported by reviewdog 🐶
constant 9223372036854775808 overflows int64) (typecheck)

midaz/pkg/os.go

Line 52 in e0d8962

if val > int64(^uint(0)>>1) || val < int64(^uint(0)>>1+1) {

🚫 [golint] reported by reviewdog 🐶
constant 9223372036854775808 overflows int64) (typecheck)

midaz/pkg/os.go

Line 52 in e0d8962

if val > int64(^uint(0)>>1) || val < int64(^uint(0)>>1+1) {

🚫 [golint] reported by reviewdog 🐶
constant 9223372036854775808 overflows int64) (typecheck)

midaz/pkg/os.go

Line 52 in e0d8962

if val > int64(^uint(0)>>1) || val < int64(^uint(0)>>1+1) {

🚫 [golint] reported by reviewdog 🐶
constant 9223372036854775808 overflows int64) (typecheck)

midaz/pkg/os.go

Line 52 in e0d8962

if val > int64(^uint(0)>>1) || val < int64(^uint(0)>>1+1) {

🚫 [golint] reported by reviewdog 🐶
constant 9223372036854775808 overflows int64) (typecheck)

midaz/pkg/os.go

Line 52 in e0d8962

if val > int64(^uint(0)>>1) || val < int64(^uint(0)>>1+1) {

🚫 [golint] reported by reviewdog 🐶
constant 9223372036854775808 overflows int64) (typecheck)

midaz/pkg/os.go

Line 52 in e0d8962

if val > int64(^uint(0)>>1) || val < int64(^uint(0)>>1+1) {

🚫 [golint] reported by reviewdog 🐶
constant 9223372036854775808 overflows int64) (typecheck)

midaz/pkg/os.go

Line 52 in e0d8962

if val > int64(^uint(0)>>1) || val < int64(^uint(0)>>1+1) {

🚫 [golint] reported by reviewdog 🐶
constant 9223372036854775808 overflows int64) (typecheck)

midaz/pkg/os.go

Line 52 in e0d8962

if val > int64(^uint(0)>>1) || val < int64(^uint(0)>>1+1) {

🚫 [golint] reported by reviewdog 🐶
constant 9223372036854775808 overflows int64) (typecheck)

midaz/pkg/os.go

Line 52 in e0d8962

if val > int64(^uint(0)>>1) || val < int64(^uint(0)>>1+1) {

🚫 [golint] reported by reviewdog 🐶
constant 9223372036854775808 overflows int64) (typecheck)

midaz/pkg/os.go

Line 52 in e0d8962

if val > int64(^uint(0)>>1) || val < int64(^uint(0)>>1+1) {

🚫 [golint] reported by reviewdog 🐶
constant 9223372036854775808 overflows int64) (typecheck)

midaz/pkg/os.go

Line 52 in e0d8962

if val > int64(^uint(0)>>1) || val < int64(^uint(0)>>1+1) {

pkg/os.go Outdated Show resolved Hide resolved
pkg/os.go Outdated Show resolved Hide resolved
pkg/os.go Outdated Show resolved Hide resolved
pkg/os.go Outdated Show resolved Hide resolved
pkg/os.go Outdated Show resolved Hide resolved
pkg/os.go Outdated Show resolved Hide resolved
pkg/os.go Outdated Show resolved Hide resolved
pkg/os.go Outdated Show resolved Hide resolved
pkg/os.go Outdated Show resolved Hide resolved
pkg/os.go Outdated Show resolved Hide resolved
MartinezAvellan
MartinezAvellan reviewed Dec 12, 2024
View reviewed changes
Copy link
Member

@MartinezAvellan MartinezAvellan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, check this lines:

components/transaction/internal/adapters/postgres/operation/operation.postgresql.go Show resolved Hide resolved
@qnen qnen added the don't merge Don't merge this PR label Dec 12, 2024
@qnen qnen marked this pull request as draft December 12, 2024 12:55
@qnen qnen marked this pull request as ready for review December 12, 2024 15:14
@qnen qnen merged commit ae11b42 into develop Dec 12, 2024
7 checks passed
@lerian-studio-midaz-push-bot
Copy link

🎉 This PR is included in version 1.31.0-beta.19 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lerian-studio-midaz-push-bot lerian-studio-midaz-push-bot[bot] lerian-studio-midaz-push-bot[bot] left review comments

@maxwelbm maxwelbm maxwelbm approved these changes

@MartinezAvellan MartinezAvellan MartinezAvellan approved these changes

@ClaraTersi ClaraTersi ClaraTersi approved these changes

Assignees

@qnen qnen

Labels
domain:onboarding Responsible for the initial configuration of the ledger domain:portfolio Responsible for creating accounts domain:transactions Responsible for transactions and operations don't merge Don't merge this PR feature New feature released on @develop
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement pagination rules
4 participants
@qnen @ClaraTersi @MartinezAvellan @maxwelbm