Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/MIDAZ-253 #254

Merged
merged 19 commits into from
Nov 14, 2024
Merged

Feature/MIDAZ-253 #254

merged 19 commits into from
Nov 14, 2024

Conversation

MartinezAvellan
Copy link
Member

Midaz Pull Request Checklist

Pull Request Type

  • Auth
  • Infra
  • Ledger
  • Mdz
  • Transaction
  • Pipeline
  • Documentation

Checklist

Please check each item after it's completed.

  • I have tested these changes locally.
  • I have updated the documentation accordingly.
  • I have added necessary comments to the code, especially in complex areas.
  • I have ensured that my changes adhere to the project's coding standards.
  • I have checked for any potential security issues.
  • I have ensured that all tests pass.
  • I have updated the version appropriately (if applicable).
  • I have confirmed this code is ready for review.

Additional Notes

Obs: Please, always remember to target your PR to develop branch instead of main.

@MartinezAvellan MartinezAvellan self-assigned this Nov 14, 2024
@MartinezAvellan MartinezAvellan requested a review from a team as a code owner November 14, 2024 11:12
@MartinezAvellan MartinezAvellan linked an issue Nov 14, 2024 that may be closed by this pull request
Add reviewdog on golang-lint #253
Closed
@MartinezAvellan MartinezAvellan added don't merge Don't merge this PR feature New feature dependencies Pull requests that update a dependency file infra Infrastructure improvements and additions labels Nov 14, 2024
@MartinezAvellan MartinezAvellan removed a link to an issue Nov 14, 2024
Add reviewdog on golang-lint #253
Closed
@MartinezAvellan MartinezAvellan linked an issue Nov 14, 2024 that may be closed by this pull request
Add reviewdog on golang-lint #253
Closed
@MartinezAvellan MartinezAvellan changed the base branch from main to develop November 14, 2024 11:16
@MartinezAvellan MartinezAvellan changed the title feat/MIDAZ-253 Feature/MIDAZ-253 Nov 14, 2024
@MartinezAvellan MartinezAvellan removed the don't merge Don't merge this PR label Nov 14, 2024
@MartinezAvellan MartinezAvellan added the don't merge Don't merge this PR label Nov 14, 2024
@MartinezAvellan MartinezAvellan changed the base branch from develop to main November 14, 2024 12:25
lerian-studio-midaz-push-bot[bot]
lerian-studio-midaz-push-bot bot previously requested changes Nov 14, 2024
View reviewed changes
Copy link

@lerian-studio-midaz-push-bot lerian-studio-midaz-push-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull requests to main can only come from develop or hotfix branches. Please change the source branch.

@MartinezAvellan MartinezAvellan changed the base branch from main to develop November 14, 2024 12:41
@MartinezAvellan MartinezAvellan changed the base branch from develop to main November 14, 2024 12:51
lerian-studio-midaz-push-bot[bot]
lerian-studio-midaz-push-bot bot reviewed Nov 14, 2024
View reviewed changes
Copy link

@lerian-studio-midaz-push-bot lerian-studio-midaz-push-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull requests to main can only come from develop or hotfix branches. Please change the source branch!!!

@MartinezAvellan MartinezAvellan changed the base branch from main to develop November 14, 2024 13:13
lerian-studio-midaz-push-bot[bot]
lerian-studio-midaz-push-bot bot reviewed Nov 14, 2024
View reviewed changes
Copy link

@lerian-studio-midaz-push-bot lerian-studio-midaz-push-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull requests to main can only come from develop or hotfix branches. Please change the source branch!!!

@MartinezAvellan MartinezAvellan changed the base branch from develop to main November 14, 2024 13:20
lerian-studio-midaz-push-bot[bot]
lerian-studio-midaz-push-bot bot reviewed Nov 14, 2024
View reviewed changes
Copy link

@lerian-studio-midaz-push-bot lerian-studio-midaz-push-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull requests to main can only come from develop, release or hotfix branches. Please change the base!!!

lerian-studio-midaz-push-bot[bot]
lerian-studio-midaz-push-bot bot reviewed Nov 14, 2024
View reviewed changes
Copy link

@lerian-studio-midaz-push-bot lerian-studio-midaz-push-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull requests to main can only come from develop, release or hotfix branches. Please change base!!!

lerian-studio-midaz-push-bot[bot]
lerian-studio-midaz-push-bot bot reviewed Nov 14, 2024
View reviewed changes
Copy link

@lerian-studio-midaz-push-bot lerian-studio-midaz-push-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull requests to main can only come from develop, release or hotfix branches. Please change base!!!

@MartinezAvellan MartinezAvellan changed the base branch from main to develop November 14, 2024 13:38
@MartinezAvellan MartinezAvellan changed the base branch from develop to main November 14, 2024 13:44
lerian-studio-midaz-push-bot[bot]
lerian-studio-midaz-push-bot bot reviewed Nov 14, 2024
View reviewed changes
Copy link

@lerian-studio-midaz-push-bot lerian-studio-midaz-push-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull requests to main can only come from develop, release or hotfix branches. Please change base!!!

lerian-studio-midaz-push-bot[bot]
lerian-studio-midaz-push-bot bot previously requested changes Nov 14, 2024
View reviewed changes
Copy link

@lerian-studio-midaz-push-bot lerian-studio-midaz-push-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull requests to main can only come from develop or hotfix branches. Please change base!!!

@MartinezAvellan MartinezAvellan changed the base branch from main to develop November 14, 2024 13:49
@MartinezAvellan MartinezAvellan merged commit ef3a549 into develop Nov 14, 2024
10 checks passed
@MartinezAvellan MartinezAvellan removed the don't merge Don't merge this PR label Nov 14, 2024
@lerian-studio-midaz-push-bot
Copy link

🎉 This PR is included in version 1.29.0-beta.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@lerian-studio-midaz-push-bot
Copy link

🎉 This PR is included in version 1.29.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qnen qnen qnen approved these changes

@ClaraTersi ClaraTersi ClaraTersi approved these changes

@lerian-studio-midaz-push-bot lerian-studio-midaz-push-bot[bot] lerian-studio-midaz-push-bot[bot] left review comments

Assignees

@MartinezAvellan MartinezAvellan

Labels
dependencies Pull requests that update a dependency file feature New feature infra Infrastructure improvements and additions released on @develop released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add reviewdog on golang-lint
3 participants
@MartinezAvellan @ClaraTersi @qnen