Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/MIDAZ-294 #297

Merged
merged 8 commits into from
Nov 25, 2024
Merged

Refactor/MIDAZ-294 #297

merged 8 commits into from
Nov 25, 2024

Conversation

MartinezAvellan
Copy link
Member

Midaz Pull Request Checklist

Pull Request Type

  • Auth
  • Infra
  • Ledger
  • Mdz
  • Transaction
  • Pipeline
  • Documentation

Checklist

Please check each item after it's completed.

  • I have tested these changes locally.
  • I have updated the documentation accordingly.
  • I have added necessary comments to the code, especially in complex areas.
  • I have ensured that my changes adhere to the project's coding standards.
  • I have checked for any potential security issues.
  • I have ensured that all tests pass.
  • I have updated the version appropriately (if applicable).
  • I have confirmed this code is ready for review.

Additional Notes

Obs: Please, always remember to target your PR to develop branch instead of main.

@MartinezAvellan MartinezAvellan changed the base branch from main to develop November 25, 2024 18:07
@MartinezAvellan MartinezAvellan requested a review from a team as a code owner November 25, 2024 18:07
lerian-studio-midaz-push-bot[bot]
lerian-studio-midaz-push-bot bot previously requested changes Nov 25, 2024
View reviewed changes
Copy link

@lerian-studio-midaz-push-bot lerian-studio-midaz-push-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull requests to main can only come from develop or hotfix branches. Please change base!!!

@MartinezAvellan MartinezAvellan self-assigned this Nov 25, 2024
@MartinezAvellan MartinezAvellan added refactor Refactor the code domain:transactions Responsible for transactions and operations labels Nov 25, 2024
@MartinezAvellan MartinezAvellan linked an issue Nov 25, 2024 that may be closed by this pull request
Midaz change arch on TRANSACTION #294
Closed
@MartinezAvellan MartinezAvellan added the don't merge Don't merge this PR label Nov 25, 2024
@MartinezAvellan MartinezAvellan changed the title Refactor/midaz 294 Refactor/MIDAZ-294 Nov 25, 2024
@MartinezAvellan MartinezAvellan merged commit a24def6 into develop Nov 25, 2024
9 checks passed
@lerian-studio-midaz-push-bot
Copy link

🎉 This PR is included in version 1.29.0-beta.11 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@lerian-studio-midaz-push-bot
Copy link

🎉 This PR is included in version 1.29.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxwelbm maxwelbm maxwelbm approved these changes

@qnen qnen qnen approved these changes

@ClaraTersi ClaraTersi ClaraTersi approved these changes

@lerian-studio-midaz-push-bot lerian-studio-midaz-push-bot[bot] lerian-studio-midaz-push-bot[bot] left review comments

Assignees

@MartinezAvellan MartinezAvellan

Labels
domain:transactions Responsible for transactions and operations don't merge Don't merge this PR refactor Refactor the code released on @develop released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Midaz change arch on TRANSACTION
5 participants
@MartinezAvellan @ClaraTersi @qnen @maxwelbm @lerian-studio