Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unify codeql/lint/sec/unit 🐛 #357

Merged
merged 22 commits into from
Dec 4, 2024
Merged

Conversation

MartinezAvellan
Copy link
Member

Midaz Pull Request Checklist

Pull Request Type

  • Auth
  • Infra
  • Ledger
  • Mdz
  • Transaction
  • Pipeline
  • Documentation

Checklist

Please check each item after it's completed.

  • I have tested these changes locally.
  • I have updated the documentation accordingly.
  • I have added necessary comments to the code, especially in complex areas.
  • I have ensured that my changes adhere to the project's coding standards.
  • I have checked for any potential security issues.
  • I have ensured that all tests pass.
  • I have updated the version appropriately (if applicable).
  • I have confirmed this code is ready for review.

Additional Notes

Obs: Please, always remember to target your PR to develop branch instead of main.

@MartinezAvellan MartinezAvellan requested a review from a team as a code owner December 3, 2024 16:30
Copy link

what-the-diff bot commented Dec 3, 2024

PR Summary

  • Removal of the CodeQL Workflow File
    The existing .github/workflows/codeql.yml workflow file has been removed.

  • Combined Analysis Workflow
    A new, comprehensive workflow file named .github/workflows/go-combined-analysis.yml has been introduced. This file includes:

    • CodeQL analysis for Go: Assists in discovering and dealing with security vulnerabilities in the code.
    • GoLangCI-Lint: This tool helps in analyzing the quality of the code and ensures adherence to coding standards.
    • GoSec: This component helps with the identification of potential security problems in the code.
    • A unit testing job: Specifically, it runs tests located in the components/ledger directory to validate the proper functioning of the individual units of code.
  • Deletion of Outdated Workflow Files
    Outdated workflow files namely:

    • .github/workflows/golangci-lint.yml
    • .github/workflows/gosec.yml
    • .github/workflows/unit-tests.yml
      have been removed.

This consolidation enhances the workflow, reduces duplication, and promises better, more secure code.

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@MartinezAvellan MartinezAvellan self-assigned this Dec 3, 2024
@MartinezAvellan MartinezAvellan added test Create new or update tests don't merge Don't merge this PR infra Infrastructure improvements and additions labels Dec 3, 2024
Copy link

@lerian-studio-midaz-push-bot lerian-studio-midaz-push-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull requests to main can only come from develop or hotfix branches. Please change base!!!

@MartinezAvellan MartinezAvellan changed the base branch from develop to main December 3, 2024 19:13
Copy link

@lerian-studio-midaz-push-bot lerian-studio-midaz-push-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull requests to main can only come from develop or hotfix branches. Please change base!!!

@MartinezAvellan MartinezAvellan changed the base branch from develop to main December 3, 2024 19:35
Copy link

@lerian-studio-midaz-push-bot lerian-studio-midaz-push-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull requests to main can only come from develop or hotfix branches. Please change base!!!

@MartinezAvellan MartinezAvellan added feature New feature refactor Refactor the code feature request New ideas and removed don't merge Don't merge this PR labels Dec 4, 2024
@MartinezAvellan MartinezAvellan merged commit 9d40d08 into develop Dec 4, 2024
7 checks passed
@lerian-studio-midaz-push-bot
Copy link

🎉 This PR is included in version 1.31.0-beta.9 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New ideas feature New feature infra Infrastructure improvements and additions refactor Refactor the code released on @develop test Create new or update tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants