You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When approving you PR, Shashi thought he was approving the black background theme. You'll notice in your closed PR, this is what you were showing your PR preview to be. However when I ran storybook, the Welcome page was in light mode. I'm not sure if this was an intentional change you made, but I believe Shashi wants it in dark mode.
The font in Storybook for the Welcome page and even the components are off, it's using a type of sans serif when it shouldn't be and it should be using the font we're using for the app
The spacing was better in the previous version of your screenshot
Mai is listed as documentation engineer when she isn't supposed to be
The text was updated successfully, but these errors were encountered:
So I just created a new branch for this on my new machine and it looks nothing like what I remember seeing on the stream from a few weeks back. The texts, spacing, etc. was correct with what I had most recently built and specified in the CSS.
However, the color change was intentional. Without using additional add-ons for Storybook, I am not able to get the theme correct, and I felt that was outside of the scope of the ticket. I thought I had addressed this, but it was close to a month ago, so who knows. The way I did it prior (the original screenshot with the dark background) was by wrapping the entire page in tags, but as we know, that broke the functionality of the stories.
I believe fixing this will go hand-in-hand with #588 this ticket.
When approving you PR, Shashi thought he was approving the black background theme. You'll notice in your closed PR, this is what you were showing your PR preview to be. However when I ran storybook, the Welcome page was in light mode. I'm not sure if this was an intentional change you made, but I believe Shashi wants it in dark mode.
The font in Storybook for the Welcome page and even the components are off, it's using a type of sans serif when it shouldn't be and it should be using the font we're using for the app
The spacing was better in the previous version of your screenshot
Mai is listed as documentation engineer when she isn't supposed to be
The text was updated successfully, but these errors were encountered: