Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Storybook Welcome Page #621

Open
choir241 opened this issue Oct 25, 2024 · 1 comment
Open

Fix Storybook Welcome Page #621

choir241 opened this issue Oct 25, 2024 · 1 comment
Assignees
Labels
documentation Improvements or additions to documentation p0

Comments

@choir241
Copy link
Contributor

choir241 commented Oct 25, 2024

  • When approving you PR, Shashi thought he was approving the black background theme. You'll notice in your closed PR, this is what you were showing your PR preview to be. However when I ran storybook, the Welcome page was in light mode. I'm not sure if this was an intentional change you made, but I believe Shashi wants it in dark mode.

  • The font in Storybook for the Welcome page and even the components are off, it's using a type of sans serif when it shouldn't be and it should be using the font we're using for the app

  • The spacing was better in the previous version of your screenshot

  • Mai is listed as documentation engineer when she isn't supposed to be

@choir241 choir241 converted this from a draft issue Oct 25, 2024
@shashilo shashilo added documentation Improvements or additions to documentation p0 labels Oct 25, 2024
@FurrerW
Copy link
Contributor

FurrerW commented Nov 14, 2024

So I just created a new branch for this on my new machine and it looks nothing like what I remember seeing on the stream from a few weeks back. The texts, spacing, etc. was correct with what I had most recently built and specified in the CSS.

Image

However, the color change was intentional. Without using additional add-ons for Storybook, I am not able to get the theme correct, and I felt that was outside of the scope of the ticket. I thought I had addressed this, but it was close to a month ago, so who knows. The way I did it prior (the original screenshot with the dark background) was by wrapping the entire page in tags, but as we know, that broke the functionality of the stories.

I believe fixing this will go hand-in-hand with #588 this ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation p0
Projects
Development

No branches or pull requests

3 participants