Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in Maphper\Relation\One? #73

Open
ckrudelux opened this issue Mar 22, 2023 · 0 comments
Open

Typo in Maphper\Relation\One? #73

ckrudelux opened this issue Mar 22, 2023 · 0 comments

Comments

@ckrudelux
Copy link

Current code:

public function __construct(\Maphper\Maphper $mapper, $parentField, $localField, array $criteria = []) {
        if ($criteria) $mapper = $mapper->filter($this->criteira);

	$this->mapper = $mapper;
	$this->parentField = $parentField;
	$this->localField = $localField;
}

$this->criteira probably should be $criteria losing the $this and correct the spelling matching the argument.

The fixed version:

public function __construct(\Maphper\Maphper $mapper, $parentField, $localField, array $criteria = []) {
        if ($criteria) $mapper = $mapper->filter(criteria);

	$this->mapper = $mapper;
	$this->parentField = $parentField;
	$this->localField = $localField;
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant