Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Instant implementations & Add Safety Docs #724

Merged
merged 1 commit into from
Sep 24, 2023

Conversation

CryZe
Copy link
Collaborator

@CryZe CryZe commented Sep 24, 2023

This updates the implementations that we use for Instant:

  1. On Apple platforms we now use the recommended APIs directly. All platforms that are supported by Rust supported that API now.
  2. On Linux we always use CLOCK_BOOTTIME, because Rust does not support any kernels anymore that don't support it.
  3. All the unsafe blocks now have safety documentation.

This updates the implementations that we use for `Instant`:

1. On Apple platforms we now use the recommended APIs directly. All
   platforms that are supported by Rust supported that API now.
2. On Linux we always use `CLOCK_BOOTTIME`, because Rust does not
   support any kernels anymore that don't support it.
3. All the unsafe blocks now have safety documentation.
@CryZe CryZe added enhancement An improvement for livesplit-core. code quality Affects the quality of the code. labels Sep 24, 2023
@CryZe CryZe added this to the v0.14 milestone Sep 24, 2023
@CryZe CryZe merged commit 25aa0cf into LiveSplit:master Sep 24, 2023
77 checks passed
@CryZe CryZe deleted the instant-impl-and-safety branch September 24, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Affects the quality of the code. enhancement An improvement for livesplit-core.
Projects
Development

Successfully merging this pull request may close these issues.

1 participant