-
-
Notifications
You must be signed in to change notification settings - Fork 969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: split server and inputs into their own groups #2594
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2594 +/- ##
==========================================
+ Coverage 9.69% 10.70% +1.00%
==========================================
Files 97 87 -10
Lines 17524 12765 -4759
Branches 8204 6180 -2024
==========================================
- Hits 1699 1366 -333
+ Misses 13050 10328 -2722
+ Partials 2775 1071 -1704
Flags with carried forward coverage won't be shown. Click here to find out more.
|
91f5661
to
de943f3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is touching every source file in the project, maybe it's a good opportunity to take care of this as well? #2186
@ReenigneArcher I was trying to avoid as much conflict as possible, but can be done, or in a future PR too. Can we force the rules to be different only for |
098210f
to
2f169db
Compare
3250336
to
0425cc5
Compare
5188aa1
to
5e1d3b1
Compare
Due to recent changes to the docs, all the doc changes can be dropped from this PR. |
4410c61
to
bbd3287
Compare
690939e
to
0e4cc2c
Compare
f385a5b
to
1aca214
Compare
724d535
to
ef923da
Compare
0c50c78
to
a329d9f
Compare
chore: fix weird imports chore: fix sys tray import error chore: fix clang code style refactor: mouse, keyboard and touch now on their own namespaces fix: make platf_input a singleton refactor: better isolation lint: remove import and space lint: import order docs: refactor docs too lint: new line at the end build: glob linking input/server build: full src glob chore: rebase fixes chore: revert doc changes docs(src): apply new patterns from LizardByte#2763 chore: fixes from code review
a329d9f
to
49aa9d7
Compare
Quality Gate failedFailed conditions See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
Description
Breaking the project in smaller pieces will make the project easier to contribute and maintain in the future, it's not a major rewrite, just moving files or splitting a single file into many without major refactors.
Moves the following files to the
server
folder:Moves the following input to the
input
folder and split it into:Screenshot
Issues Fixed or Closed
Type of Change
.github/...
)Checklist
Branch Updates
LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.