[Bug] - map2loop crashes if required fields contain null

[lachlangrose]

Version

3.1.12, 0.1.3

Bug Description

@markjessell has tried to make a model from waxi data and map2loop was crashing when the alt_unitname_column contained null values.

Minimal reproducible example

n/a

Expected Behavior

Add a check to make sure the required columns actually contain valid data. If not raise an exception.

Actual Behavior

m2l crashes

Additional Context

No response

Environment

all

Severity

• Low
• Medium
• High
• Critical

[AngRodrigues]

@lachlangrose @markjessell were the null values just empty cells on the shapefile, or wrong dtype?

[markjessell]

Often geosurvey shapefiles provide incomplete data for various fields. Numerical are also often stored as strings to add to the fun, or may have alpha symbols such as > or ? that prevent correct input. Mark Jessell Professor/ Western Australian Fellow Centre for Exploration Targeting/ SES • M006, Perth WA 6009 Australia T +61 8 6488 5803 • E ***@***.***

…

________________________________ From: AngRodrigues ***@***.***> Sent: Thursday, November 28, 2024 12:36:06 PM To: Loop3D/map2loop ***@***.***> Cc: Mark Jessell ***@***.***>; Mention ***@***.***> Subject: Re: [Loop3D/map2loop] [Bug] - map2loop crashes if required fields contain null (Issue #138) @lachlangrose<https://github.com/lachlangrose> @markjessell<https://github.com/markjessell> were the null values just empty cells on the shapefile, or wrong dtype? — Reply to this email directly, view it on GitHub<#138 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABUBSYB5PAX67FBNLGCD7JT2C2MTNAVCNFSM6AAAAABOMSXHASVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMBVGI2DKOJXGY>. You are receiving this because you were mentioned.Message ID: ***@***.***>

[lachlangrose]

Empty, from memory - but if they were all empty they may have been the wrong datatype as well!

[AngRodrigues]

Ok, thanks, I'll have a look.