Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A way to not comment when the diff is successful #28

Closed
WyriHaximus opened this issue Dec 5, 2024 · 2 comments · Fixed by #29
Closed

A way to not comment when the diff is successful #28

WyriHaximus opened this issue Dec 5, 2024 · 2 comments · Fixed by #29
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@WyriHaximus
Copy link

For PR's like WyriHaximusNet/helm-charts#127 I honestly don't care for the passing diffs and am only interested in the failing one(s). It's not a high priority for me; it's just a nice feature that improves the quality of life.
@WyriHaximus WyriHaximus changed the title A way to not command when the diff is successful A way to not comment when the diff is successful Dec 5, 2024
@LouisBrunner LouisBrunner added enhancement New feature or request good first issue Good for newcomers labels Dec 5, 2024
@LouisBrunner
Copy link
Owner

I really like this, will look into it.

@LouisBrunner LouisBrunner mentioned this issue Dec 6, 2024
Merged
@LouisBrunner
Copy link
Owner

Released as v2.2.0, you can now use notify_issue: failure to only get a comment on failures.

Thanks again for your suggestions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: improve notify_issue to be able to choose when the comment is created LouisBrunner/diff-action
2 participants
@WyriHaximus @LouisBrunner