Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UniformSpider masks the opposite side of the aperture when strut_width is large. #236

Closed
LouisDesdoigts opened this issue Jun 22, 2023 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@LouisDesdoigts
Copy link
Owner

So an odd bug here, example:

transmission = dl.UniformSpider(1, 1.9, softening=0).transmission(256, 4)
plt.imshow(transmission)
plt.colorbar()
Screenshot 2023-06-22 at 11 42 08 am

Cool works as expected here. However if we push the strut_width up to 2, the opposite side of the spider becomes occulted:

transmission = dl.UniformSpider(1, 2., softening=0).transmission(256, 4)
plt.imshow(transmission)
plt.colorbar()
Screenshot 2023-06-22 at 11 41 46 am

This seems to be related the the softening parameter:

transmission = dl.UniformSpider(1, 2., softening=2).transmission(256, 4)
plt.imshow(transmission)
plt.colorbar()
Screenshot 2023-06-22 at 11 40 58 am

I haven't had time to dive into this properly, but I suspect that this is related to #224.

Would to hear your thoughts @Jordan-Dennis

@LouisDesdoigts LouisDesdoigts added the bug Something isn't working label Jun 22, 2023
@LouisDesdoigts
Copy link
Owner Author

Fixed with #246

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants