Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oversample in MFT? #251

Closed
benjaminpope opened this issue Sep 9, 2023 · 1 comment
Closed

oversample in MFT? #251

benjaminpope opened this issue Sep 9, 2023 · 1 comment

Comments

@benjaminpope
Copy link
Collaborator

in a clean python environment using the latest pip install dlux to get dLux==0.13.2, I find

import dLux as dl
help(dl.MFT)

gives

class MFT(Propagator)
 |  MFT(*args, **kwargs)
 |  
 |  A Propagator class designed to propagate a wavefront to a plane that is
 |  defined in Cartesian units (ie metres/pixel).
 |  
 |  Attributes
 |  ----------
 |  npixels : int
 |      The number of pixels in the output plane.
 |  pixel_scale : Array, metres/pixel or radians/pixel
 |      The pixel scale in the output plane, measured in metres per pixel.
 |  focal_length : Array, metres
 |      The effective focal length of the lens/mirror this propagator
 |      represents. If None, the pixel_scale is taken to be in radians/pixel,
 |      else it is taken to be in metres/pixel.
 |  inverse : bool
 |      Should the propagation be performed in the inverse direction.

when it should have oversample - has propagators.py been neglected in a recent release or something?

@LouisDesdoigts
Copy link
Owner

Fixed with #246

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants