Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

critic activation function may be wrong #13

Open
yuh8 opened this issue Nov 18, 2021 · 0 comments
Open

critic activation function may be wrong #13

yuh8 opened this issue Nov 18, 2021 · 0 comments

Comments

@yuh8
Copy link

yuh8 commented Nov 18, 2021

tanh activation is used for critic output which limits the output range between -1 and 1. However, the self.reward which is used as ground truth for critic training is discounted cumulative sum of all rewards which can easily exceed 1. Is tanh a sensible activation for loss?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yuh8