Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid unrequired copen #3

Open
LucHermitte opened this issue Mar 15, 2017 · 0 comments
Open

Avoid unrequired copen #3

LucHermitte opened this issue Mar 15, 2017 · 0 comments
Assignees

Comments

@LucHermitte
Copy link
Owner

BTW used to execute copen in foreground compilation in order to know whether errors have occurred.
In background compilation (through Vim 8 +job), we have the information though other means. In consequence, we shouldn't need to execute copen if the qf window is already opened -- executing it triggers pointless events.

However, lh#btw#build#_show_error() is also executed in order to:

  • resize the qf window,
  • apply syntax highlighting to qf buffer,
  • apply syntax hooks to qf buffer/window

These features may be required. May be, the first one could be achieved though other means. For the other ones, the BTW-filters will need to register whether they are doing anything -- some may even execute filename/message filtering on the fly (in btw/job_build.vim s:callbackCB())

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant