Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use React new Context API #227

Closed
gpoulet opened this issue Feb 26, 2019 · 7 comments
Closed

use React new Context API #227

gpoulet opened this issue Feb 26, 2019 · 7 comments

Comments

@gpoulet
Copy link

gpoulet commented Feb 26, 2019

No description provided.

@jtanguy
Copy link

jtanguy commented Dec 1, 2020

I'm willing to rework the react client for an up-to-date API, with the newer Context API and some custom hooks if you want.

Are there any needed features ? I've seen caching in other issues, are there any specifics ? Should a cache invalidation purge everything, or just a path ?

@larousso
Copy link

larousso commented Dec 2, 2020

That would awesome !
For the cache feature, at the moment you have a sort of cache if you use a router. You have the choice to call the server on the page change or keep data.
I think that keeping the same data during a session is ok but not more.

@jtanguy
Copy link

jtanguy commented Dec 30, 2020

Is it possible to have a chat about about the react client features ? I have a POC of the react client using hooks, it is quite smaller compared to the current implementation.
However, there are some obscure or undocumented features that I don't really understand: multiple providers, the possibility to provide an array of paths in the feature component, etc.

I would not want to break these features if they are useful for some

@larousso
Copy link

Hi, we could talk about that next week, i'am on holiday right now.

@gpoulet
Copy link
Author

gpoulet commented Dec 30, 2020 via email

@StevenTew
Copy link

Hi, how far did this get?

@jtanguy
Copy link

jtanguy commented Nov 18, 2021

I had a POC at some point, but I probably lost it. I remember that the core features were quick to implement.
My main concerns at the time were user context (to provide context for A/B and some custom strategies) and #488.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

6 participants