Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename smtps to submissions #364

Closed
fastlorenzo opened this issue Aug 20, 2024 · 5 comments · May be fixed by #369
Closed

Rename smtps to submissions #364

fastlorenzo opened this issue Aug 20, 2024 · 5 comments · May be fixed by #369
Assignees
@fastlorenzo
Labels
enhancement New feature or request Stale

Comments

@fastlorenzo
Copy link
Collaborator

fastlorenzo commented Aug 20, 2024 •
edited
Loading

Is your feature request related to a problem? Please describe.
The protocol for port 465 is Submission and not SMTP.

Describe the solution you'd like
Replace smtps with submissions in

helm-charts/mailu/values.yaml

Line 628 in cfc2b7b

## @param ingress.proxyProtocol.smtps Enable PROXY protocol for SMTPS (465/tcp)

and

helm-charts/mailu/values.yaml

Line 687 in cfc2b7b

## @param front.externalService.ports.smtps Expose SMTP port (TLS) - 465/tcp

Make sure it stays backward compatible by supporting smtps until the next major release.

Describe alternatives you've considered
N/A

Additional context
https://datatracker.ietf.org/doc/html/rfc8314#section-7.3
@fastlorenzo fastlorenzo added the enhancement New feature or request label Aug 20, 2024
@fastlorenzo fastlorenzo self-assigned this Aug 20, 2024
@fastlorenzo fastlorenzo changed the title Rename smpts to submissions Rename smtps to submissions Aug 20, 2024
@WebSpider WebSpider mentioned this issue Sep 10, 2024
Open
@github-actions GitHub Actions
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Sep 20, 2024
@github-actions GitHub Actions
Copy link
Contributor

This issue was closed because it has been stalled for 5 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 25, 2024
@fastlorenzo fastlorenzo reopened this Sep 25, 2024
@fastlorenzo fastlorenzo removed the Stale label Sep 25, 2024
@WebSpider
Copy link
Contributor

@fastlorenzo anything else that needs to be done to the PR?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 7, 2024

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Nov 7, 2024
@github-actions GitHub Actions
Copy link
Contributor

This issue was closed because it has been stalled for 5 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fastlorenzo fastlorenzo

Labels
enhancement New feature or request Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename SMTPS to Submissions and deprecate old variable WebSpider/mailu-helm-charts
2 participants
@WebSpider @fastlorenzo