Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nx affected is not correct #354

Open
Lp-Francois opened this issue Jun 28, 2023 · 0 comments
Open

nx affected is not correct #354

Lp-Francois opened this issue Jun 28, 2023 · 0 comments

Comments

@Lp-Francois
Copy link

Bug Report

Current behavior

Completely ignore the nx-set-shas action, advised by the documentation: https://nx.dev/recipes/ci/monorepo-ci-github-actions

The base is not correct in this action, even if nx-set-shas set it before.

Screenshot 2023-06-28 at 17 03 20

Expected behavior

Don't override NX_BASE if it is set in the environment variables

Possible Solution

It should use the NX_BASE environment variable by default, to leverage nx-set-shas action

Others:

Latest version 3.2.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Lp-Francois