Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change x and y to ii and jj in input@axis values #25

Open
joanma747 opened this issue Sep 26, 2018 · 5 comments
Open

change x and y to ii and jj in input@axis values #25

joanma747 opened this issue Sep 26, 2018 · 5 comments

Comments

@joanma747
Copy link
Contributor

Can we change x and y in input@axis values?

Reason. Mathematical formulation of projection usually reserve to "x" and "y" for projected coordinates.
See, for example: https://proj4.org/operations/projections/merc.html but there are many more.

I would like to have ii and jj to suggest that they are in "pixels" and not in projected coordinates. We cannot use "i" and "j" because they are already taken.

If accepted, remember to change accordingly the "5 Examples" useful diagram

@prushforth
Copy link
Member

Currently, the concept of TCRS is created to encapsulate the discussion of coordinate systems in web maps, such that it should be natural to discuss how the client coordinate system is related to the various coordinate reference systems that arise in discussions. Scalable Vector Graphics and Cascading Style Sheets have created the "x" and "y" terminology and coordinate system definitions that we need to work with. This terminology exists also in Leaflet. As such I don't think it wise to attempt to change from that terminology.

@joanma747
Copy link
Contributor Author

In MapML, x,y are associated with "pixel" coordinates with origin in the top left corner of the tiled space. are associated with tcrs. SVG does not have a tiled space, CSS does not have tiled space.
Leaflet uses x,y twice in here: https://leafletjs.com/reference-1.3.4.html. The first one in the URL template. In this case x,y are tilematrix coordinates (tilecol and tilerow). The second time it is map coordinates (with origin in the map extent). Non of them are tcrs coordinates with origin in the top let corner of the tiled space.
In fact, by defining x,y with "pixel" coordinates "with origin in the top left corner of the tiled space", MapML is contradicting Leaflet, CSS and SVG.

@prushforth
Copy link
Member

SVG does not have a tiled space, CSS does not have tiled space.

My only point is that they use axis names x and y, very specifically that the y axis is inverted from all(?) geospatial y axes and that MapML's x and y axes should be as similar as possible, in particular the axis orientation!

Leaflet uses x,y twice

Leaflet internally uses x and y per their definitions on the Web. It comes up all the time when programming with Leaflet.

Non of them are tcrs coordinates with origin in the top let corner of the tiled space.

MapML is contradicting Leaflet, CSS and SVG.

The origin of CSS and SVG coordinate systems is the top left corner. The SVG spec says:

the initial viewport coordinate system (and therefore the initial user coordinate system) must have its origin at the top/left of the viewport, with the positive x-axis pointing towards the right, the positive y-axis pointing down,

Coordinate systems in SVG are very malleable, and this is something that CRS, including TCRS don't share with SVG. But at least we can make our axis names and orientations the same.

@joanma747
Copy link
Contributor Author

In the TCRS big table of the current version of MapML I accidentally spoted this text in the captions:
"Origin (x,y)".
The way it is used (pcrs coordinates) is i contradiction with the way x,y is defined in 'input@axis' (pixel coordinates).
May I suggest to change it to "Origin (Easting, Northing)" to eliminate possible confusions.

@joanma747 joanma747 reopened this Oct 2, 2018
@prushforth
Copy link
Member

May I suggest to change it to "Origin (Easting, Northing)" to eliminate possible confusions.

How about adding the axis name/ abbreviation to the coordinate itself? I noticed that there is 'n/a' listed under the origin of WGS84, which should be (0,0)?

We would then have E/N for the pcrs origins and lon/lat for the WGS84 origin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants