Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YouTube Button in Mini Player #187

Closed
Preston159 opened this issue Feb 19, 2016 · 2 comments
Closed

YouTube Button in Mini Player #187

Preston159 opened this issue Feb 19, 2016 · 2 comments

Comments

@Preston159
Copy link

Preston159 commented Feb 19, 2016

In the controls in the mini player is the same YouTube button which appears in the full-sized music player. However, when clicking this button, the YouTube video begins to play, but audio only. It then becomes impossible to pause the YouTube audio without first switching back to the full-sized player. In addition, upon switching to the full-sized player, the YouTube video is anchored to the top left of the player rather than being centred as it is when clicking the button in the full-sized player.
image

@MarshallOfSound
Copy link
Owner

OK so first off, casually landing the YouTube API ToS reference wasn't cool man... I don't even use the YouTube API so lets slow down with the ToS nonsense.

With that out of the way, this is semi relevant to
GPMDP/gmusic-mini-player.js#1

The logic required to fix this would have to go into https://github.com/MarshallOfSound/gmusic-mini-player.js but unfortunately I do not have access to this "youtube button" so can't test anything....

If you want to take a shot at a PR into that mini player library I'll take a look and review it. Other than that, not much I can do here. If you don't want to try fix it please raise it again as an issue on this repo

@MarshallOfSound
Copy link
Owner

@Preston159 And sarcasm like that really isn't needed. My point was simply that you basically accused me of publicly breaking the ToS of a product I don't even use...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants