Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date based state? #14

Open
acarter24 opened this issue Dec 5, 2023 · 2 comments
Open

Date based state? #14

acarter24 opened this issue Dec 5, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@acarter24
Copy link

Is there a reason this tap doesn't make use of state to avoid querying past dates repeatedly?

Currently, the campaign status current value gets overwritten to all the past dates. If state / replication key was employed, you could maintain a record of status over time.

@ReubenFrankel ReubenFrankel added the enhancement New feature or request label Dec 6, 2023
@ReubenFrankel
Copy link

Hi @acarter24! Nope, no reason - just not implemented yet. I'll discuss this with the team and leave any updates here, or feel free to open a PR if you like. 🙂

@acarter24
Copy link
Author

acarter24 commented Dec 8, 2023

Thanks, I am also including a report which is like adgroups, but with a date segment to give historical data at the lowest grain, so I can aggregate groups up to a campaign over time. Would that be something you would be interested in? My only concern would be the volume of data generated, perhaps it can be an optional stream by default if such a thing is possible?

Edit: Just thinking about the state issue, I'm not sure this can be done without flattening the json. I can only set replication_key to be a string, no way to point at a sub-element of the of the segments object which is what I would need to do with the current structure. I'll have a think

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants