From 07e6b8a08471cdbbd099dd33d2bd26b046258a91 Mon Sep 17 00:00:00 2001 From: danielpdwalker Date: Thu, 21 Oct 2021 12:22:59 +0100 Subject: [PATCH] Readme update, removed unneeded testing logging in streams --- README.md | 8 ++++---- tap_openweathermap/streams.py | 3 --- 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/README.md b/README.md index f86437d..b0e9553 100644 --- a/README.md +++ b/README.md @@ -12,6 +12,7 @@ pipx install tap-openweathermap ## Configuration +#### Expected Env Vars ```bash TAP_OPENWEATHERMAP_API_KEY=1234567890 TAP_OPENWEATHERMAP_CURRENT_WEATHER_CITY_NAME=london @@ -21,12 +22,11 @@ TAP_OPENWEATHERMAP_FORECAST_WEATHER_LATTITUDE=51.5085 `api_key` is required for authentication, see the "Source Authentication and Authorization" section for how to get one. `current_weather_city_name` is required, and the api will return current weather data for the supplied city name. - -`forecast_weather_longitude` is optional, you need to provide this to get forecast data. -`forecast_weather_lattitude` is optional, you need to provide this to get forecast data. +`forecast_weather_longitude` is required, you need to provide this to get forecast data. +`forecast_weather_lattitude` is required, you need to provide this to get forecast data. You can get the longitude and lattitude of a city by requesting its current weather, setting the city name to the ``current_weather_city_name` setting. -The longitude and lattidue will be returned as part of the curren +The longitude and lattidue will be returned as part of the current_weather_stream. To get the values for your first call just google "city_name" coords. ### Accepted Config Options diff --git a/tap_openweathermap/streams.py b/tap_openweathermap/streams.py index 60df54d..baba4b2 100644 --- a/tap_openweathermap/streams.py +++ b/tap_openweathermap/streams.py @@ -55,9 +55,6 @@ def get_url_params( params["q"] = self.config.get("current_weather_city_name") params["appid"] = self.config.get("api_key") - self.logger.info("sfhsfuihsduisiofshduffjdisdfsjsiofdjidosj") - self.logger.info(self.config) - return params