-
-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
logo: simplify basic usage, allow for extended functionality #679
Comments
I am hesitant. For the logo this is rather difficult, because it's not only the logo to display but posibliy a title, too. This title may or may not be given in the logo image but as separate text. While the first case often result in a rectangualar logo, the latter usually (but not always) results in a squarish logo. Also, often there are font requirements for the logo title, if given as text - as well as color requirements if a light or dark style was selected. This is only an incomplete list of some of the options. I could go on and on... Even if only a stripped down solution is implemented in the theme itself, I bet it would end up in a lot of support questions. It's not off the table, but I have to think about it. |
Well, I see two use cases here: (a) I have just a logo (image), and (b) I need something fancier (e.g. logo plus text or some extra formatting).
Edit: This would also be backwards compatible, i.e. won't break any existing setups :) |
I started working on this. But as I expected, this ends in some extensive (but backwards compatible) changes to do it "right". |
currently only the additional name option is recognized
While the groundwork was layed in 5.24.0 to make the icon configurable, the finishing step was postponed to a later release due to time constraints. |
Currently, to use your own logo, you first have to define a custom partial "layouts/partials/logo.html" and reference an image or the like there (see https://mcshelby.github.io/hugo-theme-relearn/basics/customization/index.html#change-the-logo).
This works, but is rather cumbersome for users. Could a similar solution be implemented for logos like for favicons? I.e. as default, an image file called "logo.png" (or logo.svg) is searched for in the folder "static/images/" and if I have other needs, I need to create the extra partial?
This way, the logo and the favicon would be treated symmetrically.
The text was updated successfully, but these errors were encountered: