From f1b26f5bf66cfa02e02acee122f254faa80b51bc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Edgar=20Ram=C3=ADrez=20Mondrag=C3=B3n?= <16805946+edgarrmondragon@users.noreply.github.com> Date: Wed, 10 Jan 2024 23:09:42 -0600 Subject: [PATCH] fix: Use `NULLS FIRST` for incremental replication (#83)

The default null ordering is NULLS LAST, regardless of ascending or descending sort order.

References: * https://docs.aws.amazon.com/athena/latest/ug/select.html#select-parameters * https://trino.io/docs/current/sql/select.html#order-by-clause --- tap_athena/client.py | 1 + 1 file changed, 1 insertion(+) diff --git a/tap_athena/client.py b/tap_athena/client.py index 4a3f51f..6416db2 100644 --- a/tap_athena/client.py +++ b/tap_athena/client.py @@ -39,3 +39,4 @@ class AthenaStream(SQLStream): """The Stream class for Athena.""" connector_class = AthenaConnector + supports_nulls_first = True